Add conn shutdown error log. Improve other error log messages #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyograo
reviewed
Oct 26, 2016
| end | ||
| connection.on_blocked do | ||
| @logger.warn("RabbitMQ connection blocked! Check your RabbitMQ instance!", | ||
| :url => connection_url(connection)) |
There was a problem hiding this comment.
are we sure this (connection) does not log any auth information?
There was a problem hiding this comment.
I see masking is done below
There was a problem hiding this comment.
I never print the password.
suyograo
reviewed
Oct 26, 2016
| def connection_url(connection) | ||
| user_pass = connection.user ? "#{connection.user}:XXXXXX@" : "" | ||
| protocol = params["ssl"] ? "amqps" : "amqp" | ||
| "#{protocol}://#{user_pass}#{connection.host}:#{connection.port}#{connection.vhost}" |
There was a problem hiding this comment.
Ah I see this here. Ignore my comment above
suyograo
reviewed
Oct 26, 2016
| :url => connection_url(connection)) | ||
| end | ||
| connection.on_unblocked do | ||
| @logger.warn("RabbitMQ connection unblocked!", :url => connection_url(connection)) |
There was a problem hiding this comment.
Should we make this info?
There was a problem hiding this comment.
This has been warn for a long time. I think it is something that is warning level, normally queues should not be blocked unless there's a problem.
|
LGTM |
andrewvc
force-pushed
the
better_error_logging
branch
from
b8323e3
to
1b90559
Compare
|
Andrew Cholakian merged this into the following branches!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a connection died it would recover, but there would be no indication of an error. This was a problem in logstash-plugins/logstash-input-rabbitmq#76
Including the URL will help users debug things.