Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: when detecting version, log correctly #714

Merged

Conversation

Projects
None yet
2 participants
@yaauie
Copy link
Contributor

commented Dec 14, 2017

@maximum_seen_major_version will always be falsy here, use major instead

logging: when detecting version, log correctly
`@maximum_seen_major_version` will always be falsy here, use `major` instead
@jsvd

jsvd approved these changes Dec 14, 2017

Copy link
Contributor

left a comment

derp...nice catch. LGTM

@yaauie yaauie force-pushed the yaauie:fix/log-message-on-ES-version-detection branch from db98422 to 0e759db Dec 15, 2017

@yaauie yaauie merged commit 316aa59 into logstash-plugins:master Dec 19, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.