Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle escaping of index names #831

Closed
wants to merge 3 commits into from

Conversation

@robbavey
Copy link
Contributor

robbavey commented Jan 25, 2019

Ensure that path entries containing '/' characters, such as those using
date math are handled correctly.

Also adds an integration test target using logstash source

Ensure that path entries containing '/' characters, such as those using
date math are handled correctly.

Also adds an integration test target using logstash source
@robbavey robbavey force-pushed the robbavey:escape_fix branch from 165a9c7 to 13bce96 Jan 25, 2019
@robbavey robbavey force-pushed the robbavey:escape_fix branch from 13bce96 to 961ea47 Jan 25, 2019
@robbavey robbavey requested a review from jsvd Jan 28, 2019
@robbavey

This comment has been minimized.

Copy link
Contributor Author

robbavey commented Jan 28, 2019

@jsvd - This PR now has integration tests that will test ilm (and other elasticsearch functions) against latest logstash source rather than 5.4.0 that was being pulled in previously

@robbavey

This comment has been minimized.

Copy link
Contributor Author

robbavey commented Jan 29, 2019

@jsvd is this good to go?

@jsvd

This comment has been minimized.

Copy link
Contributor

jsvd commented Jan 29, 2019

@robbavey sorry, not yet, I'm testing it today

@jsvd
jsvd approved these changes Jan 29, 2019
Copy link
Contributor

jsvd left a comment

LGTM, tested a few use cases manually, the settings were respected and aliases configured and correctly written to. 👍

@elasticsearch-bot

This comment has been minimized.

Copy link

elasticsearch-bot commented Jan 29, 2019

Rob Bavey merged this into the following branches!

Branch Commits
master 7d95eb5, d725e97, cf1f170
elasticsearch-bot pushed a commit that referenced this pull request Jan 29, 2019
Fixes #831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.