From cfbceb66a61d280c57b4f4b4da196d17d070e31f Mon Sep 17 00:00:00 2001
From: Darcy Ye <darcyye@silverhand.io>
Date: Wed, 3 Apr 2024 14:18:50 +0800
Subject: [PATCH] chore(console): update style

chore(console): update style
---
 .../SubmitFormChangesActionBar/index.tsx      |  4 +-
 .../MonacoCodeEditor/index.module.scss        | 20 ++++++---
 .../MainContent/MonacoCodeEditor/index.tsx    | 44 ++++++++++---------
 .../ScriptSection/index.module.scss           |  8 ++--
 .../MainContent/ScriptSection/index.tsx       |  2 +-
 .../SettingsSection/index.module.scss         |  1 +
 .../MainContent/index.module.scss             |  8 +++-
 .../CustomizeJwtDetails/MainContent/index.tsx |  1 +
 .../CustomizeJwtDetails/utils/config.tsx      | 10 +++--
 9 files changed, 61 insertions(+), 37 deletions(-)

diff --git a/packages/console/src/components/SubmitFormChangesActionBar/index.tsx b/packages/console/src/components/SubmitFormChangesActionBar/index.tsx
index 140a887fbf4..d403c323508 100644
--- a/packages/console/src/components/SubmitFormChangesActionBar/index.tsx
+++ b/packages/console/src/components/SubmitFormChangesActionBar/index.tsx
@@ -11,6 +11,7 @@ type Props = {
   onSubmit: () => Promise<void>;
   onDiscard: () => void;
   confirmText?: AdminConsoleKey;
+  className?: string;
 };
 
 function SubmitFormChangesActionBar({
@@ -19,9 +20,10 @@ function SubmitFormChangesActionBar({
   confirmText = 'general.save_changes',
   onSubmit,
   onDiscard,
+  className,
 }: Props) {
   return (
-    <div className={classNames(styles.container, isOpen && styles.active)}>
+    <div className={classNames(styles.container, isOpen && styles.active, className)}>
       <div className={styles.actionBar}>
         <Button
           size="medium"
diff --git a/packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/index.module.scss b/packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/index.module.scss
index 9e6bbb69164..2896c53cc34 100644
--- a/packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/index.module.scss
+++ b/packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/index.module.scss
@@ -71,13 +71,23 @@
     }
   }
 
-  .editorContainer {
-    position: relative;
+  .body {
+    display: flex;
+    flex-direction: column;
     flex-grow: 1;
 
-    &.dashboardOpen {
-      flex-grow: 0;
-      height: 50%;
+    .editorContainer {
+      position: relative;
+      flex-grow: 1;
+
+      &.dashboardOpen {
+        flex-grow: 0;
+        height: 50%;
+      }
+    }
+
+    .resultPanel {
+      border-radius: 0 0 8px 8px;
     }
   }
 }
diff --git a/packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/index.tsx b/packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/index.tsx
index a8b6993acef..d9ff37055b4 100644
--- a/packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/index.tsx
+++ b/packages/console/src/pages/CustomizeJwtDetails/MainContent/MonacoCodeEditor/index.tsx
@@ -176,28 +176,30 @@ function MonacoCodeEditor({
           {actionButtons}
         </div>
       </header>
-      <div
-        ref={containerRef}
-        className={classNames(styles.editorContainer, dashboard && styles.dashboardOpen)}
-      >
-        {activeModel && (
-          <Editor
-            height={editorHeight}
-            language={activeModel.language}
-            path={activeModel.name}
-            theme="logto-dark"
-            options={{
-              ...defaultOptions,
-              ...activeModel.options,
-            }}
-            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- empty string is falsy
-            value={value || activeModel.defaultValue}
-            onMount={handleEditorDidMount}
-            onChange={onChange}
-          />
-        )}
+      <div className={styles.body}>
+        <div
+          ref={containerRef}
+          className={classNames(styles.editorContainer, dashboard && styles.dashboardOpen)}
+        >
+          {activeModel && (
+            <Editor
+              height={editorHeight}
+              language={activeModel.language}
+              path={activeModel.name}
+              theme="logto-dark"
+              options={{
+                ...defaultOptions,
+                ...activeModel.options,
+              }}
+              // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- empty string is falsy
+              value={value || activeModel.defaultValue}
+              onMount={handleEditorDidMount}
+              onChange={onChange}
+            />
+          )}
+        </div>
+        {dashboard && <DashBoard {...dashboard} className={styles.resultPanel} />}
       </div>
-      {dashboard && <DashBoard {...dashboard} />}
     </div>
   );
 }
diff --git a/packages/console/src/pages/CustomizeJwtDetails/MainContent/ScriptSection/index.module.scss b/packages/console/src/pages/CustomizeJwtDetails/MainContent/ScriptSection/index.module.scss
index 0e6e77891dd..963c6162d9d 100644
--- a/packages/console/src/pages/CustomizeJwtDetails/MainContent/ScriptSection/index.module.scss
+++ b/packages/console/src/pages/CustomizeJwtDetails/MainContent/ScriptSection/index.module.scss
@@ -1,10 +1,12 @@
 @use '@/scss/underscore' as _;
 
-.scripeSection {
-  position: relative;
+.scriptSection {
+  position: sticky;
+  top: 0;
   min-width: 50%;
 
   .fixHeightWrapper {
+    margin-bottom: _.unit(3);
     position: absolute;
     inset: 0;
     display: flex;
@@ -12,7 +14,7 @@
   }
 
   .codeEditor {
-    min-height: 200px;
+    min-height: 400px;
     flex-grow: 1;
   }
 }
diff --git a/packages/console/src/pages/CustomizeJwtDetails/MainContent/ScriptSection/index.tsx b/packages/console/src/pages/CustomizeJwtDetails/MainContent/ScriptSection/index.tsx
index 0f74ee71d61..e1212e94d77 100644
--- a/packages/console/src/pages/CustomizeJwtDetails/MainContent/ScriptSection/index.tsx
+++ b/packages/console/src/pages/CustomizeJwtDetails/MainContent/ScriptSection/index.tsx
@@ -74,7 +74,7 @@ function ScriptSection() {
   }, [setTestResult, t, testResult]);
 
   return (
-    <div className={styles.scripeSection}>
+    <div className={styles.scriptSection}>
       <div className={styles.fixHeightWrapper}>
         <Controller
           control={control}
diff --git a/packages/console/src/pages/CustomizeJwtDetails/MainContent/SettingsSection/index.module.scss b/packages/console/src/pages/CustomizeJwtDetails/MainContent/SettingsSection/index.module.scss
index cc0b98018a2..194168eb7ba 100644
--- a/packages/console/src/pages/CustomizeJwtDetails/MainContent/SettingsSection/index.module.scss
+++ b/packages/console/src/pages/CustomizeJwtDetails/MainContent/SettingsSection/index.module.scss
@@ -61,4 +61,5 @@
 
 .flexGrow {
   flex: 1;
+  min-height: 200px;
 }
diff --git a/packages/console/src/pages/CustomizeJwtDetails/MainContent/index.module.scss b/packages/console/src/pages/CustomizeJwtDetails/MainContent/index.module.scss
index d76315fc6ea..41785f8a321 100644
--- a/packages/console/src/pages/CustomizeJwtDetails/MainContent/index.module.scss
+++ b/packages/console/src/pages/CustomizeJwtDetails/MainContent/index.module.scss
@@ -14,8 +14,6 @@
   }
 
   > * {
-    margin-bottom: _.unit(6);
-
     &:first-child {
       margin-right: _.unit(3);
       flex: 9;
@@ -26,3 +24,9 @@
     }
   }
 }
+
+.submitActionBar {
+  &.overwrite {
+    margin-top: 0;
+  }
+}
diff --git a/packages/console/src/pages/CustomizeJwtDetails/MainContent/index.tsx b/packages/console/src/pages/CustomizeJwtDetails/MainContent/index.tsx
index a2298678ac4..05d9b3afb3a 100644
--- a/packages/console/src/pages/CustomizeJwtDetails/MainContent/index.tsx
+++ b/packages/console/src/pages/CustomizeJwtDetails/MainContent/index.tsx
@@ -90,6 +90,7 @@ function MainContent<T extends LogtoJwtTokenKeyType>({
         isOpen={isDirty || action === 'create'}
         isSubmitting={isSubmitting}
         confirmText={action === 'create' ? 'general.create' : 'general.save_changes'}
+        className={classNames(styles.submitActionBar, styles.overwrite)}
         onDiscard={
           // If the form is in create mode, navigate back to the previous page
           action === 'create'
diff --git a/packages/console/src/pages/CustomizeJwtDetails/utils/config.tsx b/packages/console/src/pages/CustomizeJwtDetails/utils/config.tsx
index bf5341b403e..d3d828de9ec 100644
--- a/packages/console/src/pages/CustomizeJwtDetails/utils/config.tsx
+++ b/packages/console/src/pages/CustomizeJwtDetails/utils/config.tsx
@@ -32,7 +32,7 @@ declare global {
 
   export interface Exports {
     /**
-     * This function is called to get custom claims for the JWT token.
+     * This function is called during the access token generation process to get custom claims for the JWT token.
      * 
      * @param {${JwtCustomizerTypeDefinitionKey.AccessTokenPayload}} token -The JWT token.
      * @param {Data} data - Logto internal data that can be used to pass additional information
@@ -56,7 +56,7 @@ declare global {
 
   export interface Exports {
     /**
-     * This function is called to get custom claims for the JWT token.
+     * This function is called during the access token generation process to get custom claims for the JWT token.
      * 
      * @param {${JwtCustomizerTypeDefinitionKey.ClientCredentialsPayload}} token -The JWT token.
      * 
@@ -72,7 +72,8 @@ export { exports as default };
 `;
 
 export const defaultAccessTokenJwtCustomizerCode = `/**
-* This function is called to get custom claims for the JWT token.
+* This function is called during the access token generation process to get custom claims for the JWT token.
+* Limit custom claims to under 50KB.
 * 
 * @param {${JwtCustomizerTypeDefinitionKey.AccessTokenPayload}} token -The JWT token.
 * @param {Data} data - Logto internal data that can be used to pass additional information
@@ -87,7 +88,8 @@ exports.getCustomJwtClaims = async (token, data, envVariables) => {
 }`;
 
 export const defaultClientCredentialsJwtCustomizerCode = `/**
-* This function is called to get custom claims for the JWT token.
+* This function is called during the access token generation process to get custom claims for the JWT token.
+* Limit custom claims to under 50KB.
 *
 * @param {${JwtCustomizerTypeDefinitionKey.ClientCredentialsPayload}} token -The JWT token.
 * @param {${JwtCustomizerTypeDefinitionKey.EnvironmentVariables}} [envVariables] - The environment variables.