Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back-end protocol 3 support #9

Closed
ai opened this issue Apr 12, 2020 · 6 comments
Closed

Add back-end protocol 3 support #9

ai opened this issue Apr 12, 2020 · 6 comments

Comments

@ai
Copy link
Member

@ai ai commented Apr 12, 2020

Version 3 of back-end protocol bring changes:

  1. password → secret
  2. ["error", meta.id, stack] must contain action ID.
  3. An error outside of action processing (where we do not know meta.id) the server should answer 500 HTTP code
@anaumov
Copy link
Contributor

@anaumov anaumov commented Oct 10, 2020

@ai let's jump into protocol v4?

@ai
Copy link
Member Author

@ai ai commented Oct 10, 2020

Yeap. Having Protocol 4 will be the best. You can start adding 4 to PR for 3.

@anaumov
Copy link
Contributor

@anaumov anaumov commented Oct 11, 2020

@ai I'll create new one. Let's release gem with protocol 3. What do you think?

@ai
Copy link
Member Author

@ai ai commented Oct 11, 2020

@anaumov @dreikanter yeap, it is better to release gem for 3 and then release for 4.

@dreikanter
Copy link
Collaborator

@dreikanter dreikanter commented Oct 13, 2020

@anaumov @ai I will release V3 support as a separate gem version on RubyGems later this week. Since #11 is already merged to master, it would be nice to have V4 support implementation on a separate branch to simplify further merge process.

BTW, do we have breaking changes between V3 and V4 protocols?

@ai
Copy link
Member Author

@ai ai commented Oct 13, 2020

Yeap V4 is not compatible with V3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants