Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uWebSocket #31

Merged
merged 4 commits into from May 3, 2017

Conversation

Projects
None yet
2 participants
@sairus2k
Copy link
Contributor

commented Apr 28, 2017

No description provided.

sairus2k added some commits Apr 28, 2017

#17. Use uWebSockets
Replace ws with uws, fixed tests
#17. Use uWebSockets
Fix getting client remote address
@ai

This comment has been minimized.

Copy link
Member

commented Apr 28, 2017

@sairus2k note, that you still have problem in Travis CI

@sairus2k

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2017

@ai

This comment has been minimized.

Copy link
Member

commented Apr 28, 2017

OK, I will try to look on my machine. Maybe it is related to concurrency. Or to yarn lock?

sairus2k added some commits Apr 30, 2017

Debug on Travis-CI
Check for client remote address
Debug on Travis-CI
Try to connect client to ip address not to hostname

@sairus2k sairus2k closed this Apr 30, 2017

@sairus2k sairus2k reopened this Apr 30, 2017

@sairus2k

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2017

@ai Probably, localhost on Travic-CI resolves to ipv6 address
This is the issue:
https://github.com/uWebSockets/uWebSockets/issues/342
Then it fails only for node version 6.10.2 with another error. I restarted build using close and reopen pull request and all tests passed.

@ai

This comment has been minimized.

Copy link
Member

commented Apr 30, 2017

Great invastigation. Sorry, I stock on Autoprefixer 7 release :(

@ai ai merged commit 96b0413 into logux:master May 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ai

This comment has been minimized.

Copy link
Member

commented May 3, 2017

Thanks. Whatis your Twitter and VK accounts for announce?

@sairus2k

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.