Permalink
Browse files

Minor optimization: cache single instances of some utility objects us…

…ed in BgPosition.getValues() rather than creating them every time.
  • Loading branch information...
Jason Johnston
Jason Johnston committed Sep 3, 2010
1 parent bb37d8f commit dae857350305f6c74ecb8800c1c86f1de3980e04
Showing with 10 additions and 9 deletions.
  1. +10 −9 sources/BgPosition.js
View
@@ -5,7 +5,11 @@
*/
PIE.BgPosition = (function() {
- var length_fifty = new PIE.Length( '50%' );
+ var length_fifty = new PIE.Length( '50%' ),
+ length_zero = PIE.Length.ZERO,
+ vert_idents = { 'top': 1, 'center': 1, 'bottom': 1 },
+ horiz_idents = { 'left': 1, 'center': 1, 'right': 1 },
+ vals = [ 'left', length_zero, 'top', length_zero ];
function BgPosition( tokens ) {
@@ -24,14 +28,11 @@ PIE.BgPosition = (function() {
if( !this._values ) {
var tokens = this.tokens,
len = tokens.length,
- length_zero = PIE.Length.ZERO,
- type_ident = PIE.Tokenizer.Type.IDENT,
- type_length = PIE.Tokenizer.Type.LENGTH,
- type_percent = PIE.Tokenizer.Type.PERCENT,
- type, value,
- vert_idents = { 'top': 1, 'center': 1, 'bottom': 1 },
- horiz_idents = { 'left': 1, 'center': 1, 'right': 1 },
- vals = [ 'left', length_zero, 'top', length_zero ];
+ identType = PIE.Tokenizer.Type,
+ type_ident = identType.IDENT,
+ type_length = identType.LENGTH,
+ type_percent = identType.PERCENT,
+ type, value;
// If only one value, the second is assumed to be 'center'
if( len === 1 ) {

0 comments on commit dae8573

Please sign in to comment.