Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some border styles not implemented #10

Closed
lojjic opened this issue May 22, 2010 · 1 comment

Comments

Projects
None yet
1 participant
@lojjic
Copy link
Owner

commented May 22, 2010

The following border-style values are not yet honored when redrawing the border for the purposes of rounding corners:

groove
ridge
inset
outset

All of these styles require shifting the border-color, so we will need to add an method for doing that to the Color class. This will also require a way to convert named colors to numeric values which can be shifted.

lojjic pushed a commit that referenced this issue Nov 24, 2011

@lojjic

This comment has been minimized.

Copy link
Owner Author

commented Nov 24, 2011

Fixed.

In case anyone stumbles across this looking for how to do something similar, it turns out VML has the native capability of performing color manipulation, so this did not require any special JS logic to implement the darkening/lightening of colors. You just have to add a "lighten(n)" or "darken(n)" to the end of the color value string. See http://msdn.microsoft.com/en-us/library/bb250525%28v=vs.85%29.aspx#color.adjustments

@lojjic lojjic closed this Nov 24, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.