Regular Expressions and JSMIN #231

Closed
seangates opened this Issue Aug 2, 2012 · 5 comments

3 participants

@seangates

JSMIN breaks when using the regex shorthand: /someregex/gi

Because of this, I had to change all the shorthand versions to their RegExp object equivalents.

Would it be possible to get them changed?

Thanks!
Sean

P.S.: It's transformed how we deal with IE, so big props for building this.

@lojjic
Owner

Sorry I'm confused, how does JSMIN come into play? PIE is compressed using Closure Compiler in advanced mode.

@seangates
@domenic

JSMIN is such a bad piece of software, I feel sorry for you for having to deal with that requirement. If it doesn't understand JavaScript syntax like regular expressions I wonder why you are using it on JavaScript programs?

@seangates
@lojjic
Owner

I've given it a lot of thought, and have decided I'm not going to make this change. I definitely sympathize with you being stuck using JSMin, but I don't feel that accommodating a poor tool is worth hurting everyone else with an increased download size. Sorry, but you're going to have to continue modifying it until you can phase out JSMin (or get the bug fixed in JSMin)

@lojjic lojjic closed this Jan 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment