Minor improvement to linear-gradient rendering #308

Merged
merged 3 commits into from Mar 16, 2015

Projects

None yet

2 participants

@ycnix
ycnix commented Mar 13, 2015

Here is a fix to an issue we faced on our project with rendering of linear gradient.
If for some reason area width or height of an element is zero then exception will be thrown in process of rendering and subsequent renderings will be skipped.
I would appreciate if you merge it into master branch.

sega added some commits Mar 13, 2015
@lojjic
Owner
lojjic commented Mar 13, 2015

Thanks for the fix!

I don't think we need the "else" block, as zero width/height is a perfectly normal case and doesn't need a warning. Do you agree?

@ycnix
ycnix commented Mar 16, 2015

You are right. I removed the 'else' block.

@lojjic lojjic merged commit 1f77b88 into lojjic:master Mar 16, 2015
@lojjic
Owner
lojjic commented Mar 16, 2015

Merged. Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment