Fix max uint64_t errors when contributing to a reserved spot #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to fill a reserved spot of a service node that is fully reserved the wallet is getting back the UINT64_MAX error code value for min_contrib_total, but not properly handling it resulting in: Error: You must contribute at least 18446744073.709551615 loki to become a contributor for this service node. Fix it to recognize the error value when filling a reserved spot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to fill a reserved spot of a service node that is fully reserved the wallet is getting back the UINT64_MAX error code value for min_contrib_total, but not properly ignoring it resulting in:
Error: You must contribute at least 18446744073.709551615 loki to become a contributor for this service node.
even when you are trying to fill your own reserved, unfilled spot.
Fix it to recognize (and ignore) the error value when filling a reserved spot.