forked from signalapp/Signal-Desktop
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loki address broadcast #157
Merged
sachaaaaa
merged 10 commits into
oxen-io:development
from
BeaudanBrown:loki-address-broadcast
Jan 30, 2019
Merged
Loki address broadcast #157
sachaaaaa
merged 10 commits into
oxen-io:development
from
BeaudanBrown:loki-address-broadcast
Jan 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachaaaaa
reviewed
Jan 30, 2019
sachaaaaa
reviewed
Jan 30, 2019
sachaaaaa
approved these changes
Jan 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The force is strong with this one !
BeaudanBrown
force-pushed
the
loki-address-broadcast
branch
from
January 30, 2019 06:15
4c09868
to
0932df9
Compare
Mikunj
approved these changes
Jan 30, 2019
…ting friends, local server now instantiated on the window, now sending online broadcast messages when the local server starts
…d p2p address and port to the window object when recieve message
BeaudanBrown
force-pushed
the
loki-address-broadcast
branch
from
January 30, 2019 23:27
0932df9
to
6ba7fb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start of P2P stuff, added a new message proto type for a loki address message
When you launch the app you "broadcast" a message to all of your friends with your P2P address info (currently just dummy data because we don't have a way to get our loki address yet) and then the recipient stores this in memory
Next up is the logic for pinging, i.e. the timers etc and then hooking in the message sending to use these addresses if the other user is "online"
Also allowing the user to manually select the port they want to use for their http server (and fall back to the node port finding thing if it doesn't work)
Fixes #154