Updated pinging logic. #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachaaaaa
reviewed
May 27, 2019
| const contactDetails = this.contactP2pDetails[pubKey]; | ||
| return !!(contactDetails && contactDetails.isOnline); | ||
| if (!this.contactP2pDetails[pubKey]) return null; | ||
| return { ...this.contactP2pDetails[pubKey] }; |
There was a problem hiding this comment.
Was this returning a reference instead of a copy?
If so, good catch.
There was a problem hiding this comment.
Ya, don't think it was affecting the actual functionality but it was picked up by the tests
Ye, now we only mark the contact is online if our p2p handshake went through successfully. |
BeaudanBrown
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few minor cases that we were missing when checking whether we should ping or just mark the user as online.
This PR simplifies that logic down according to the following diagram:
EDIT: The image is missing a connection between
Was a user marked as online before?andPing contactHere we assume:
online