Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show mentions as profile names and treat them as indivisible elements #538

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@msgmaxim
Copy link
Collaborator

commented Sep 30, 2019

When a member is selected, we create a mapping from "handle" (usually their profile name) to their pubkey. If multiple members with the same profile names are selected, one of the conflicting handles is augmented with a corresponding shortened pubkey (we use as many characters from the pubkey as necessary to avoid ambiguity). Before a message is sent, all handles are replaced with their corresponding pubkeys, and the mapping is reset.

The input/compose GUI element now has custom handling of arrow, delete and backspace keys. In particular, we make sure that a mention is treated as a single indivisible element, so if any action would result in a caret being positioned inside a mention, it will be moved either to the end or the beginning of the mention (whichever is more natural). We don't, however, handle mouse cursor in any special way yet.

@msgmaxim msgmaxim requested review from neuroscr, Mikunj and sachaaaaa Sep 30, 2019
js/views/conversation_view.js Outdated Show resolved Hide resolved
js/views/conversation_view.js Outdated Show resolved Hide resolved
@msgmaxim msgmaxim merged commit 5f3342f into loki-project:clearnet Oct 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.