Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-device] public chat #539

Open
wants to merge 8 commits into
base: multi-device
from

Conversation

@neuroscr
Copy link

commented Oct 1, 2019

One interesting minor? side-effect...

  • if you write on a slave device, it will show up on the primary device as if they wrote it. This is because the source matches your own key on the primary device.
  • if you write on a primary device, it will show up on the secondary device like another user with your name wrote it. This is because the source does NOT matches your own key on the secondary device.

Other notes:

  • fixes bug with forEach not waiting until complete (possibly causing lastGot to not be updating right)
  • moved profileName writing into serverAPI from chatAPI, since it's a server level action

Probably could:

  • remove the optimized slaveMessages system in trade for a more generalized pendingMessages queue processing function to reduce the amount of code
@neuroscr neuroscr changed the base branch from clearnet to multi-device Oct 3, 2019
@neuroscr neuroscr changed the title WIP: Multidevice publicchat Multidevice publicchat Oct 3, 2019
@neuroscr neuroscr marked this pull request as ready for review Oct 3, 2019
@neuroscr neuroscr requested a review from BeaudanBrown Oct 3, 2019
@neuroscr neuroscr modified the milestone: October Release Oct 3, 2019
@neuroscr neuroscr changed the title Multidevice publicchat [multi-device] public chat Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.