Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-device] Fix signatures being sent to file server as arraybuffer #542

Merged

Conversation

@sachaaaaa
Copy link
Collaborator

commented Oct 2, 2019

This is probably technical debt, but libloki.storage.getGrantAuthorisationForSecondaryPubKey and Signal.Data.getGrantAuthorisationForSecondaryPubKey aren't doing exactly the same.
The latter returns the authorisation from the db as is (signatures as base64) while the secondary converts them to array buffers.
Anyway, in this case we want to send the signatures as base64 to the file server.

@sachaaaaa sachaaaaa changed the title [multi-server] Fix signatures being sent to file server as arraybuffer [multi-device] Fix signatures being sent to file server as arraybuffer Oct 2, 2019
Copy link

left a comment

I don't think it possible to make a smaller PR ;)

Copy link
Collaborator

left a comment

Not familiar with the repercussions but straightforward

@sachaaaaa sachaaaaa merged commit c48f52b into loki-project:multi-device Oct 2, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sachaaaaa sachaaaaa deleted the sachaaaaa:fix_secondary_sig_fileserver branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.