Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attachment pipeline to upload and download from loki fileserver #561

merged 5 commits into from Oct 21, 2019


Copy link

BeaudanBrown commented Oct 15, 2019

Minor change to the protobuf to allow for arbitrary length strings as the attachment "id" (which are we using to store the attachment url)
Little iffy on the whole "rawBody" thing I did in app_dot_net_api, open to suggestions
This implementation currently doesn't handle upload errors, the existing signal code has an ajax system which retries 3 times with a 1 second pause before throwing a replayable error I believe. Will look into it

@BeaudanBrown BeaudanBrown requested review from neuroscr and Mikunj Oct 15, 2019
@@ -28,6 +29,7 @@ function MessageReceiver(username, password, signalingKey, options = {}) {
this.signalingKey = signalingKey;
this.username = username;
this.password = password;
this.server = WebAPI.connect({ username, password });

This comment has been minimized.

Copy link

neuroscr Oct 16, 2019

WebAPI? this is too generic to explain what it is... oh it's the ajax stuff.. hrm...

This comment has been minimized.

Copy link

BeaudanBrown Oct 16, 2019

Author Collaborator

Yeah it's not the most clear name... It's a Signal file which we actually removed all the references too early on because it was all code for contacting Signal servers, I just left put this initialiser back in to leave the attachment code mostly untouched but it definitely might make more sense to just move the put/get attachment stuff to a loki specific file and let the web api wither away?

@BeaudanBrown BeaudanBrown force-pushed the BeaudanBrown:loki-attachment branch from 934dd99 to 5710c12 Oct 17, 2019
@BeaudanBrown BeaudanBrown force-pushed the BeaudanBrown:loki-attachment branch from 42c2bb2 to f538aee Oct 21, 2019
@BeaudanBrown BeaudanBrown merged commit 2adc98a into loki-project:clearnet Oct 21, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
continuous-integration/travis-ci/pr The Travis CI build passed
@BeaudanBrown BeaudanBrown deleted the BeaudanBrown:loki-attachment branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.