Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-device] Robust sessions #586

Merged
merged 2 commits into from Oct 30, 2019

Conversation

@BeaudanBrown
Copy link
Collaborator

BeaudanBrown commented Oct 28, 2019

(Forgot the multi-device flag for the other PRs...)
The meat of the multi device work I did

I think the additions for saveAllPairingAuthorisationsFor are redundant, but I need to get some fresh eyes to figure out the minimum amount of calls that are required

  • Trigger friend request accept/received etc for the relevant secondary conversation rather than the primary
  • Build automatic friend request if you are not friends with one of the devices for any outgoing message (needs to be throttled later)
…ices and automatic friend request if not friends with a device
@BeaudanBrown BeaudanBrown requested a review from sachaaaaa Oct 28, 2019
js/models/messages.js Outdated Show resolved Hide resolved
Copy link
Collaborator

sachaaaaa left a comment

Everything looks sensible considering the complexity and the existing code.
It does feel like we're adding a bit of technical debt tho, which might be fixed in a couple of hours by analysing the pipeline carefully and locating the best places to handle sending FR to new devices when sending a message.

@BeaudanBrown

This comment has been minimized.

Copy link
Collaborator Author

BeaudanBrown commented Oct 29, 2019

Yes definitely agree on the tech debt, before we do the release we will definitely have to spend some time just ironing

@BeaudanBrown BeaudanBrown merged commit d52a08a into loki-project:multi-device Oct 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BeaudanBrown BeaudanBrown deleted the BeaudanBrown:robust-sessions branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.