Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a simple error instead of logging a failed null check #588

Merged
merged 1 commit into from Oct 30, 2019

Conversation

@BeaudanBrown
Copy link
Collaborator

BeaudanBrown commented Oct 29, 2019

No description provided.

@BeaudanBrown BeaudanBrown requested review from Mikunj and sachaaaaa Oct 29, 2019
Copy link
Collaborator

sachaaaaa left a comment

LGTM
I find the existing Signal code a bit weird, returning resolved/rejected promises but also the object directly (which is implicitly converted to a resolved promise). Would have been clearer to always return objects or throw, but hey ¯_(ツ)_/¯

@Mikunj
Mikunj approved these changes Oct 29, 2019
@BeaudanBrown BeaudanBrown merged commit 85d4519 into loki-project:clearnet Oct 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BeaudanBrown BeaudanBrown deleted the BeaudanBrown:simple-error branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.