Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross platform device linking #589

Merged
merged 1 commit into from Oct 30, 2019

Conversation

@Mikunj
Copy link
Collaborator

Mikunj commented Oct 29, 2019

We Infer pairing message type from the content and not by the field set in the protobuf

This should fix device pairing cross platform.
@Mikunj Mikunj requested review from sachaaaaa and BeaudanBrown Oct 29, 2019
Copy link
Collaborator

BeaudanBrown left a comment

Will we need to extend the proto again if we want to be able to revoke?
This seems fine tho

@Mikunj

This comment has been minimized.

Copy link
Collaborator Author

Mikunj commented Oct 29, 2019

Will we need to extend the proto again if we want to be able to revoke?
This seems fine tho

Ye, we need to sit down and decide how we're going to do revoking

@sachaaaaa

This comment has been minimized.

Copy link
Collaborator

sachaaaaa commented Oct 30, 2019

As discussed offline, revoking can be done by removing devices from the server's mapping.
Then the secondary device will have to detect that it has been removed from it's primary device mapping, and update its own mapping accordingly.
This assumes we don't want to support reassigning which device is the primary within multiple linked devices.

@BeaudanBrown BeaudanBrown merged commit 8235662 into loki-project:multi-device Oct 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.