Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select multiple messages and bulk deletion #592

Merged
merged 3 commits into from Nov 11, 2019

Conversation

@msgmaxim
Copy link
Collaborator

msgmaxim commented Oct 31, 2019

  • select multiple messages by left-clicking on them
  • when at least one message is selected it enters a multi-select mode with an additional menu to delete selected messages or cancel the selection.
messages.map(m => m.getServerId())
);
} else {
success = await channelAPI.deleteMessages([messages[0].getServerId()]);

This comment has been minimized.

Copy link
@sachaaaaa

sachaaaaa Oct 31, 2019

Collaborator

looks to me like the if/else is not necessary, unless I'm mistaken?

This comment has been minimized.

Copy link
@msgmaxim

msgmaxim Nov 6, 2019

Author Collaborator

Updated this part

@BeaudanBrown

This comment has been minimized.

Copy link
Collaborator

BeaudanBrown commented Oct 31, 2019

Not the most pressing issue but I had a suspicion and just confirmed that you can enter multi-select mode by selecting some messages then use the conversation settings cog to Delete messages, at which point you will be stuck in multi-select mode until you restart your client because there are ids in the selected list which can't be removed

@BeaudanBrown

This comment has been minimized.

Copy link
Collaborator

BeaudanBrown commented Oct 31, 2019

Well whoops actually you can still press delete or cancel

@msgmaxim msgmaxim force-pushed the msgmaxim:select-messages branch from b5c60cd to 027e17f Nov 6, 2019
@msgmaxim msgmaxim merged commit 8ed72aa into loki-project:clearnet Nov 11, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.