Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multi-device]show pairing words on paired device list #598

Conversation

@sachaaaaa
Copy link
Collaborator

sachaaaaa commented Nov 1, 2019

Since the user has no ways to know the paired device's pubkeys, show the secret words instead.
Also, refactor the creation of the secret words into its own function.
The next step is allowing the primary device to define an alias for those secondary devices.

@sachaaaaa sachaaaaa requested review from msgmaxim, Mikunj and BeaudanBrown Nov 1, 2019
@@ -190,3 +191,10 @@ for (var i in mn_words) {
}
}
}

function pubkey_to_secret_words(pubKey) {
return mn_encode(pubKey.slice(2), 'english')

This comment has been minimized.

Copy link
@msgmaxim

msgmaxim Nov 1, 2019

Collaborator

Is english going to be hardcoded?

This comment has been minimized.

Copy link
@sachaaaaa

sachaaaaa Nov 1, 2019

Author Collaborator

Well, we need a consistent pubkey to secret word mapping, so the language has to be hardcoded. If you have different languages set on your devices, you still want to read the same secret words to identify your device... Does that make sense?

@sachaaaaa sachaaaaa merged commit d350e4a into loki-project:multi-device Nov 1, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sachaaaaa sachaaaaa deleted the sachaaaaa:secret_words_on_primary_device branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.