Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public ban #652

Merged
merged 9 commits into from Nov 28, 2019

Conversation

@vincentbavitz
Copy link
Collaborator

vincentbavitz commented Nov 25, 2019

First time contributor checklist:

Contributor checklist:

Description

Added functionality to ban users from public chat as Moderator.

Please write a summary of your test approach:
Tested on public chat via 2 test cases; API request failed. API request succeeded.
UI responds with toast on success or failure.

js/models/messages.js Outdated Show resolved Hide resolved
@sachaaaaa sachaaaaa mentioned this pull request Nov 26, 2019
@sachaaaaa

This comment has been minimized.

Copy link
Collaborator

sachaaaaa commented Nov 26, 2019

Unit tests picked up some errors:

Model caught error triggering change event: TypeError: Cannot read property 'isModerator' of undefined\n    at ...
js/models/messages.js Outdated Show resolved Hide resolved
@vincentbavitz vincentbavitz force-pushed the vincentbavitz:public-ban branch from cca9339 to 6499684 Nov 28, 2019
js/models/messages.js Outdated Show resolved Hide resolved
Copy link
Collaborator

sachaaaaa left a comment

Ship it!

@vincentbavitz vincentbavitz merged commit 2e83881 into loki-project:clearnet Nov 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.