Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upEncrypted profile pic #661
Conversation
sachaaaaa
changed the title
This comment has been minimized.
This comment has been minimized.
|
I doubt this PR tackles the multi-device case, where we show the primary device's avatar for a message sent by a secondary device. Am testing this now, will post any fixes in a new PR if necessary! |
This comment has been minimized.
This comment has been minimized.
|
I have force-pushed a brand new history for this branch. |
| @@ -254,6 +266,14 @@ class LokiAppDotNetServerAPI { | |||
| return res.response.data.annotations || []; | |||
| } | |||
|
|
|||
| async setAvatar(url, profileKey) { | |||
| let value = null; | |||
| if (url && profileKey) { | |||
This comment has been minimized.
This comment has been minimized.
| @@ -254,6 +266,14 @@ class LokiAppDotNetServerAPI { | |||
| return res.response.data.annotations || []; | |||
| } | |||
|
|
|||
| async setAvatar(url, profileKey) { | |||
| let value = null; | |||
This comment has been minimized.
This comment has been minimized.
neuroscr
Dec 1, 2019
•
This should be undefined. A null is preserved but an undefined will clean up the complete annotation. This is post Sacha, I can change this after the PR.
|
|
||
| // FIXME: this is not file-server specific | ||
| // and is currently called by LokiAppDotNetAPI. | ||
| // LokiAppDotNetAPI (base) should not know about LokiFileServer. |
This comment has been minimized.
This comment has been minimized.
neuroscr
Dec 1, 2019
•
This may need to be discussed. This isn't the specific function (though it has the same name) that LokiAppDotNetAPI calls, it uses the lokiFileServerAPIFactory which is like a global singleton (analogous to our LokiPublicChatAPI).
Though I guess the concept of home server will disable when we share private keys.
sachaaaaa commentedNov 26, 2019
•
edited
setprofileSharingon every conversation to true to enable sending theprofileKeywith every messageNote that the public chat side of things will come in the next PR.EDIT: changes for public chat added in this PR but in a separate commitprofileSharingto true only before sending a friend request (FR), or after becoming friend, for private chatsshare our profileKey on the public chat only upon sending a message the first timeshare our profileKey on the public chat every time it changes, unless we've never sent any messagesEDIT2: Major re-org of this PR, please review commit by commit :)