Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickable profile #662

Merged
merged 8 commits into from Nov 29, 2019
Merged

clickable profile #662

merged 8 commits into from Nov 29, 2019

Conversation

@Bilb
Copy link
Collaborator

Bilb commented Nov 27, 2019

Make the avatars (in the conversation view) clickable to show a modal with details about the user clicked:
Show the name, the avatar and the public key of the user.
A button can be used to start a conversation with this user directly.
Should I add a "Copy pubkey" button? The pubkey is selectable already but still...

This behavior needs to be included to the issue #656 once ready.
Relates #655

Here is a screenshot (in french)
Capture d’écran_2019-11-28_16-48-10

@Bilb Bilb force-pushed the Bilb:655-clickable-profile branch from 0b11b4a to 77fcd7c Nov 27, 2019
Audric Ackermann added 4 commits Nov 27, 2019
Disable the click on avatar because before it selected the message.
OnClick on avatar -> trigger event to show the UserDetails modal with this pubkey.
@Bilb Bilb force-pushed the Bilb:655-clickable-profile branch from 77fcd7c to c61249e Nov 27, 2019
Copy link
Collaborator

sachaaaaa left a comment

Great job!
Just some small questions below :)

js/background.js Outdated Show resolved Hide resolved
js/background.js Outdated Show resolved Hide resolved
@Bilb Bilb force-pushed the Bilb:655-clickable-profile branch from d545619 to 061556b Nov 28, 2019
Copy link
Collaborator

sachaaaaa left a comment

👌 niiice

@msgmaxim msgmaxim merged commit 1020f54 into loki-project:clearnet Nov 29, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.