Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompting the user to reset session on invalid ciphertext #669

Merged
merged 2 commits into from Dec 4, 2019

Conversation

@msgmaxim
Copy link
Collaborator

msgmaxim commented Nov 28, 2019

  • On first message that we can't decrypt we show the prompt and record that we've done that (so we don't show the same dialog for every message)
  • On submit, we send an empty message with a SESSION_RESTORE flag, so we can display the message accordingly (the session reset will happen in the background in that case)
  • If some old friend request is still in the database after we restore from seed, we leave it as is (we can't really distinguish between new and old FR, and old FR won't work anymore), but perform session restoration as above rather than responding to that FR in case we've also received some undecipherable messages from that pubkey.
  • I don't use "showConfirmationDialog" because it is ugly (and would require some size tweaking to fit pubkey in one line)
@msgmaxim msgmaxim force-pushed the msgmaxim:restoration branch from 6fe7bda to 81bfa90 Nov 28, 2019
js/background.js Outdated Show resolved Hide resolved
@Mikunj
Mikunj approved these changes Dec 3, 2019
Copy link
Collaborator

Mikunj left a comment

looks good :)

@msgmaxim msgmaxim merged commit 5123fa0 into loki-project:clearnet Dec 4, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.