Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce --background to only start JSON RPC #855

Merged
merged 2 commits into from Oct 4, 2019

Conversation

@michael-loki
Copy link
Collaborator

commented Oct 4, 2019

fixes #853

what's currently broken:

  • ctrl-c to kill if you've not sent the start command(??)
fixes #853
if(_running)
{
return util::StatusObject{
{"dht", _dht->impl->ExtractStatus()},
{"services", _hiddenServiceContext.ExtractStatus()},
{"exit", _exitContext.ExtractStatus()},
{"links", _linkManager.ExtractStatus()}};
}
else
{
return util::StatusObject{{"notRunning", true}};
}
Comment for lines 113  – 124

This comment has been minimized.

Copy link
@majestrate

majestrate Oct 4, 2019

Collaborator

this should set running to true if running and return only an object with running as false in the case it's not.

if(method == "llarp.admin.start")
{
return StartRouter();
}
Comment for lines 281  – 284

This comment has been minimized.

Copy link
@majestrate

majestrate Oct 4, 2019

Collaborator

this should be llarp.admin.wakeup so we can have a llarp.admin.suspend as well

This comment has been minimized.

Copy link
@michael-loki

michael-loki Oct 4, 2019

Author Collaborator

I was thinking start + stop, versus wakeup. will defer to you though

@majestrate majestrate merged commit 7780fe0 into loki-project:dev Oct 4, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.