Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Service Node Keys as Base32z RPC Call #404

Merged
merged 7 commits into from Jan 24, 2019

Conversation

@Doy-lee
Copy link
Collaborator

Doy-lee commented Jan 24, 2019

Base32z for interop with Lokinet

Example usage:

curl -X POST http://127.0.0.1:22023/json_rpc -d '{"jsonrpc":"2.0","id":"0","method":"get_all_service_nodes_keys", "params": {"fully_funded_nodes_only": false}' -H 'Content-Type: application/json'

Fully_funded_nodes_only is defaulted to true when not specified. Specifying it will ensure the returned keys are belonging to service nodes that have completed the staking requirement.

tewinget and others added 4 commits Oct 29, 2018
currently does nothing, just a shell (that compiles)
also change the result to be vector of hex strings rather than binary keys
Base32z for Lokinet internal usage
@Doy-lee Doy-lee requested a review from msgmaxim Jan 24, 2019
src/common/loki.cpp Outdated Show resolved Hide resolved
src/cryptonote_core/cryptonote_core.h Outdated Show resolved Hide resolved

std::string loki::hex64_to_base32z(const std::string &src)
{
char buf[128] = {};

This comment has been minimized.

Copy link
@majestrate

majestrate Jan 24, 2019

this may overflow if used improperly

This comment has been minimized.

Copy link
@majestrate

majestrate Jan 24, 2019

no nevermind i am wrong

@Doy-lee Doy-lee merged commit 101f179 into loki-project:dev Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.