Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax p2p connection restrictions for non-mainnet #864

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@jagerman
Copy link

commented Oct 2, 2019

Our testnet IP distribution is far from distributed: the 1-connection-per-IP and skipping duplicate class B IPs are more of a nuissance rather than anything useful on testnet.

This turns off both when not on mainnet: the class B checking is disabled, and the connections per IP becomes 20 instead of 1.

Our testnet IP distribution is far from distributed: the
1-connection-per-IP and skipping duplicate class B IPs are more of a
nuissance rather than anything useful on testnet.
@jagerman jagerman changed the title Relax p2p connection restrictions for testnet/stagenet Relax p2p connection restrictions for non-mainnet Oct 2, 2019
@Doy-lee

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2019

You probably also need to disable the check that prints REFUSED, too many connections from the same address but that seems important for like some nodes, like the seed node and explorer even on testnet.

@jagerman

This comment has been minimized.

Copy link
Author

commented Oct 2, 2019

You probably also need to disable the check that prints REFUSED

I am not following; has_too_many_connections is the check around that message.

@Doy-lee

This comment has been minimized.

Copy link
Collaborator

commented Oct 2, 2019

Ohh, ohh .. oh.

@Doy-lee Doy-lee merged commit d3b1531 into loki-project:dev Oct 2, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.