Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Reward fudge factor #867
If the thread's rounding mode is different (because RandomX changed it in the current thread or in the thread that generated the block) then the reward calculation can be up to 1 atomic unit off. This lets those pass rather than rejecting the block. (I tested LOKI's reward calculations up to height 10M to verify that the maximum error in reward values is never off by more than 1).
- fix the broken error message which was printing "base(base+fees)" instead of "total(base+fees)". - improve the error message wording to actually indicate what the values signify. - don't use base_reward as a temporary value (the intermediate value assigned to it is completely replaced later anyway). - use some better variable names to describe what is happening here
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.