Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the overflow test for fee and block_reward in blocks #869

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@Doy-lee
Copy link
Collaborator

commented Oct 4, 2019

Fixes gen_uint_overflow_1 test, has been tested with the reward fudge PR.

Had to change the loki_chain_generator API to work the way this test wanted to use blockchain data, so the bulk of changes is renaming.

@jagerman

Copy link

left a comment

LGTM.

@@ -752,7 +752,7 @@ struct push_core_event_visitor: public boost::static_visitor<bool>
log_event("loki_blockchain_addable<cryptonote::checkpoint_t>");
cryptonote::Blockchain &blockchain = m_c.get_blockchain_storage();
bool added = blockchain.update_checkpoint(entry.data);
CHECK_AND_NO_ASSERT_MES(added == entry.can_be_added_to_blockchain, false, entry.fail_msg);
CHECK_AND_NO_ASSERT_MES(added == entry.can_be_added_to_blockchain, false, (entry.fail_msg.size() ? entry.fail_msg : "Failed to add checkpoint (no reason given)"));

This comment has been minimized.

Copy link
@jagerman

jagerman Oct 4, 2019

These seem unrelated to this PR (they seem fine, just checking that including them was intentional).

This comment has been minimized.

Copy link
@Doy-lee

Doy-lee Oct 4, 2019

Author Collaborator

Yea

@Doy-lee Doy-lee merged commit 11e6f7a into loki-project:dev Oct 4, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.