Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx burning #920

Merged
merged 6 commits into from Nov 7, 2019

Conversation

@jagerman
Copy link

jagerman commented Oct 30, 2019

This adds a tx extra field that specifies an amount of the tx fee that
must be burned; the miner can claim only (txnFee - burnFee) when
including the block, and this amount must also be satisfied for the tx
to be valid.

This will be used for the extra, burned part of blink fees and LNS fees
and any other transaction that requires fee burning in the future.

jagerman added 5 commits Oct 30, 2019
This adds a tx extra field that specifies an amount of the tx fee that
must be burned; the miner can claim only (txnFee - burnFee) when
including the block.

This will be used for the extra, burned part of blink fees and LNS fees
and any other transaction that requires fee burning in the future.
src/cryptonote_core/blockchain.cpp Outdated Show resolved Hide resolved
src/cryptonote_core/tx_pool.cpp Show resolved Hide resolved
This code references m_tx_pool.m_transactions which got removed in
Monero 11, so apparently no one has noticed or tested anything here
since then (despite adding new commits into it).
@@ -47,7 +47,7 @@ set(core_tests_sources
wallet_tools.cpp)

set(core_tests_headers
block_reward.h

This comment has been minimized.

Copy link
@Doy-lee

Doy-lee Nov 6, 2019

Collaborator

I don't think these need to be commented out, chaingen_main #if 0s the broken test cases out

This comment has been minimized.

Copy link
@jagerman

jagerman Nov 6, 2019

Author

Is there a point in compiling code that isn't going to be run?

This comment has been minimized.

Copy link
@Doy-lee

Doy-lee Nov 6, 2019

Collaborator

It's disabling at 2 places which is more inconvenient than just setting 1 place for when someone needs to fix it.

This comment has been minimized.

Copy link
@jagerman

jagerman Nov 7, 2019

Author

Okay, I'll reenable. (This was were I started adding tests until I realized it wasn't running at all -- then I tried to fix the tests, and that... didn't work out so well).

@Doy-lee
Doy-lee approved these changes Nov 6, 2019
Copy link
Collaborator

Doy-lee left a comment

Few minor changes but looks good otherwise

@Doy-lee Doy-lee merged commit 1e46dd4 into loki-project:dev Nov 7, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.