Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggegrate init service node info instead of setting members individually #934

Merged
merged 2 commits into from Nov 27, 2019

Conversation

@Doy-lee
Copy link
Collaborator

Doy-lee commented Nov 25, 2019

No description provided.

service_node_info &info = *info_ptr;
info = {};

This comment has been minimized.

Copy link
@jagerman

jagerman Nov 27, 2019

This is going to end up doing a 0 initialization of a new instance, copy (or move) that into info, then destruct the new instance. It might be cleaner to just default = 0 on the fields in the header instead so that you don't have to worry about initialization at all.

This comment has been minimized.

Copy link
@Doy-lee

Doy-lee Nov 27, 2019

Author Collaborator

And updated

@Doy-lee Doy-lee merged commit 0b8e21f into loki-project:dev Nov 27, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.