Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Build/core test fixes, incorporate LNS construct_tx revamp #939
This also merges in a manually merged #913 because the staking changes here fix up some of the redundant-ness in
Core tests are all passing as of this commit.
Edit: Also merges in core tests from #909
- Fix assert to use version_t::_count in service_node_list.cpp - Incoporate staking changes from LNS which revamp construct tx to derive more of the parameters from hf_version and type. This removes extraneous parameters that can be derived elsewhere. Also delegate setting loki_construct_tx_params into wallet2 atleast, so that callers into the wallet logic, like rpc server, simplewallet don't need bend backwards to get the HF version whereas the wallet has dedicated functions for determining the HF.