Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 2.4.2 #231

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
3 participants
@morygonzalez
Copy link
Member

commented Dec 3, 2017

  • Add support for Ruby 2.4
    • Also dropped Ruby 2.1 support, which have got EOL.
  • Update ActiveSupport to version 4.x
    • Fixes various security issues including below
      2017-12-03 13 06 40
    • Now no need to escape html manually in view ( padrino-helpers will automatically do that ).
    • This is required to support Ruby 2.4
    • This causes upgrading to padrino-helpers 0.14.1.1
  • Update .travis.yml
    • Update postgresql version used in CI
    • Removed CI build notification to IRC channel where no one is present
@@ -4,7 +4,7 @@ def fixture_path
File.expand_path(File.dirname(__FILE__) + "/../fixtures")
end

shared_context "in site" do
before { Factory(:site) }
shared_context 'in site' do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@@ -2,7 +2,7 @@

describe 'Login' do
include_context 'in site'
before { Factory(:user, :name => 'test') }
before { create(:user, :name => 'test') }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Use the new Ruby 1.9 hash syntax.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@@ -230,8 +230,8 @@

context "access tag archive page" do
before do
Factory(:tag, :name => 'lokka')
post = Factory(:post)
create(:tag, :name => 'lokka')

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Use the new Ruby 1.9 hash syntax.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Factory(:draft_post_with_tag_and_category)
@post = Post.first(:draft => true)
create(:draft_post_with_tag_and_category)
@post = Post.first(:draft => true)

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Use the new Ruby 1.9 hash syntax.

@category = Factory(:category)
@category_child = Factory(:category_child, :parent => @category)
@category = create(:category)
@category_child = create(:category_child, :parent => @category)

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Use the new Ruby 1.9 hash syntax.

@@ -32,7 +32,7 @@
context 'POST /admin/comments' do
it 'should create a new comment' do
Comment.destroy
sample = Factory.attributes_for(:comment, :entry_id => @post.id)
sample = attributes_for(:comment, :entry_id => @post.id)

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Use the new Ruby 1.9 hash syntax.

Factory(:spam_comment, :entry => @post)
@post = create(:post)
@comment = create(:comment, :entry => @post)
create(:spam_comment, :entry => @post)

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Use the new Ruby 1.9 hash syntax.

@comment = Factory(:comment, :entry => @post)
Factory(:spam_comment, :entry => @post)
@post = create(:post)
@comment = create(:comment, :entry => @post)

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Use the new Ruby 1.9 hash syntax.

association :category
after_create { |p| Factory(:tagging, :taggable_id => p.id) }
after(:create) { |p| create(:tagging, :taggable_id => p.id) }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Use the new Ruby 1.9 hash syntax.

@@ -91,9 +91,9 @@
slug 'test-draft-post'
end

factory :draft_post_with_tag_and_category, :parent => :draft_post do
factory :draft_post_with_tag_and_category, :parent => :draft_post do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Use the new Ruby 1.9 hash syntax.

@morygonzalez morygonzalez force-pushed the morygonzalez:ruby-2-4 branch from 2bb84ca to 91b8464 Dec 3, 2017

ga('create', '#{tracker}', 'auto');
ga('send', 'pageview');
</script>
EOS

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Use meaningful heredoc delimiters.

queries << "comment_content=#{params[:comment][:body]}"
queries.map! {|value| URI.encode(value) }
request = queries.join("&")
response = akismet_post host, '/1.1/comment-check', request

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

ga('create', '#{tracker}', 'auto');
ga('send', 'pageview');
</script>
EOS

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Use meaningful heredoc delimiters.

queries << "comment_content=#{params[:comment][:body]}"
queries.map! {|value| URI.encode(value) }
request = queries.join("&")
response = akismet_post host, '/1.1/comment-check', request

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@morygonzalez morygonzalez force-pushed the morygonzalez:ruby-2-4 branch from a90bafc to 6118592 Dec 3, 2017

@morygonzalez

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2017

I will make another Pull Request to hush houndci-bot.

@komagata

This comment has been minimized.

Copy link
Member

commented Dec 4, 2017

@morygonzalez Thank you so much!

@komagata komagata merged commit 52bdadc into lokka:master Dec 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound 52 violations found.

@morygonzalez morygonzalez deleted the morygonzalez:ruby-2-4 branch Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.