Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hush-up houndci-bot #232

Merged
merged 1 commit into from May 28, 2018

Conversation

Projects
None yet
3 participants
@morygonzalez
Copy link
Member

commented Dec 3, 2017

Let @houndci-bot shut his big mouse up

What I did

  • Add Rubocop and HAML-Lint to Gemfile in order to check link locally.
  • Add rules for Rubocop and HAML-Lint
    • I guessed .rubocop.yml rules from Lokka's code base
    • Some of rules that are supposed to be hard to correct are excluded. ABC Metric for instance.

What I didn't

  • Check JavaScript linter and correction.
    • Because I'm not mature on JavaScript.
@@ -1,55 +1,55 @@
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Missing magic comment # frozen_string_literal: true.

@@ -1,14 +1,14 @@
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Missing magic comment # frozen_string_literal: true.

@@ -1,8 +1,8 @@
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Missing magic comment # frozen_string_literal: true.


describe Post do
context 'with slug' do
context "with slug" do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Block has too many lines. [26/25]

@@ -1,57 +1,57 @@
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Missing magic comment # frozen_string_literal: true.

@@ -1,4 +1,4 @@
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Missing magic comment # frozen_string_literal: true.

add_filter "tmp/"
add_filter "log/"
end
require "simplecov"

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Missing magic comment # frozen_string_literal: true.

put "/admin/tags/#{@tag.id}", { :tag => { :name => 'changed' } }
context "PUT /admin/tags/:id" do
it "should change the name" do
put "/admin/tags/#{@tag.id}", { tag: { name: "changed" } }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Redundant curly braces around a hash parameter.

describe '/admin/tags' do
include_context 'admin login'
before { @tag = Factory(:tag) }
describe "/admin/tags" do

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Block has too many lines. [45/25]

@@ -1,57 +1,57 @@
require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
require File.expand_path(File.dirname(__FILE__) + "/spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 3, 2017

Missing magic comment # frozen_string_literal: true.

@@ -1,55 +1,56 @@
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
# frozen_string_literal: true
require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 4, 2017

Add an empty line after magic comments.

@@ -1,14 +1,15 @@
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
# frozen_string_literal: true
require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 4, 2017

Add an empty line after magic comments.

@@ -1,8 +1,9 @@
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
# frozen_string_literal: true
require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 4, 2017

Add an empty line after magic comments.

@@ -1,57 +1,58 @@
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
# frozen_string_literal: true
require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 4, 2017

Add an empty line after magic comments.

@@ -1,7 +1,8 @@
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
# frozen_string_literal: true
require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 4, 2017

Add an empty line after magic comments.

@@ -1,4 +1,5 @@
require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
# frozen_string_literal: true
require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 4, 2017

Add an empty line after magic comments.

add_filter "log/"
end
# frozen_string_literal: true
require "simplecov"

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 4, 2017

Add an empty line after magic comments.

This comment has been minimized.

Copy link
@morygonzalez

morygonzalez Dec 4, 2017

Author Member

😠

This comment has been minimized.

Copy link
@komagata

komagata Dec 4, 2017

Member

Ah...

before { post '/admin/login', {:name => 'wrong', :password => 'wrong'} }
it_behaves_like 'login failed'
context "when invalid username and password" do
before { post "/admin/login", { name: "wrong", password: "wrong" } }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 4, 2017

Redundant curly braces around a hash parameter.

before { post '/admin/login', {:name => 'test', :password => 'wrong'} }
it_behaves_like 'login failed'
context "when invalid password" do
before { post "/admin/login", { name: "test", password: "wrong" } }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 4, 2017

Redundant curly braces around a hash parameter.

before { post '/admin/login', {:name => 'wrong', :password => 'test'} }
it_behaves_like 'login failed'
context "when invalid username" do
before { post "/admin/login", { name: "wrong", password: "test" } }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Dec 4, 2017

Redundant curly braces around a hash parameter.

put "/admin/snippets/#{@snippet.id}", { :snippet => { :body => 'updated' } }
context "PUT /admin/snippets/:id" do
it "should update the snippet\"s body " do
put "/admin/snippets/#{@snippet.id}", { snippet: { body: "updated" } }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

context "POST /admin/snippets" do
it "should create a new snippet" do
sample = attributes_for(:snippet, name: "Created Snippet")
post "/admin/snippets", { snippet: sample }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

last_response.status.should == 404
end

it "POST request should add a comment to an article" do
post '/2011/01/09/welcome-lokka', { :check => "check", :comment => { :name => 'lokka tarou', :homepage => 'http://www.example.com/', :body => 'good entry!' } }
post "/2011/01/09/welcome-lokka", { check: "check", comment: { name: "lokka tarou", homepage: "http://www.example.com/", body: "good entry!" } }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.
Line is too long. [152/80]

end

context "POST" do
before { Comment.destroy }

it "should add a comment to an article" do
post "/#{@post.id}", { :check => "check", :comment => { :name => 'lokka tarou', :homepage => 'http://www.example.com/', :body => 'good entry!' } }
post "/#{@post.id}", { check: "check", comment: { name: "lokka tarou", homepage: "http://www.example.com/", body: "good entry!" } }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.
Line is too long. [141/80]

subject { get '/'; last_response.body }
it { should match('Test Site') }
context "/" do
subject { get "/"; last_response.body }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Do not use semicolons to terminate expressions.

it "should not create a user when two password does not match" do
user = { name: "lokka tarou",
email: "tarou@example.com",
password: "test",

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Align the elements of a hash literal if they span more than one line.

post '/admin/users', { :user => user }
it "should not create a user when two password does not match" do
user = { name: "lokka tarou",
email: "tarou@example.com",

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Align the elements of a hash literal if they span more than one line.

email: "tarou@example.com",
password: "test",
password_confirmation: "test" }
post "/admin/users", { user: user }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

user = { name: "lokka tarou",
email: "tarou@example.com",
password: "test",
password_confirmation: "test" }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Align the elements of a hash literal if they span more than one line.

it "should create a new user" do
user = { name: "lokka tarou",
email: "tarou@example.com",
password: "test",

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Align the elements of a hash literal if they span more than one line.

put "/admin/snippets/#{@snippet.id}", { :snippet => { :body => 'updated' } }
context "PUT /admin/snippets/:id" do
it "should update the snippet\"s body " do
put "/admin/snippets/#{@snippet.id}", { snippet: { body: "updated" } }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

context "POST /admin/snippets" do
it "should create a new snippet" do
sample = attributes_for(:snippet, name: "Created Snippet")
post "/admin/snippets", { snippet: sample }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

last_response.status.should == 404
end

it "POST request should add a comment to an article" do
post '/2011/01/09/welcome-lokka', { :check => "check", :comment => { :name => 'lokka tarou', :homepage => 'http://www.example.com/', :body => 'good entry!' } }
post "/2011/01/09/welcome-lokka", { check: "check", comment: { name: "lokka tarou", homepage: "http://www.example.com/", body: "good entry!" } }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.
Line is too long. [152/80]

end

context "POST" do
before { Comment.destroy }

it "should add a comment to an article" do
post "/#{@post.id}", { :check => "check", :comment => { :name => 'lokka tarou', :homepage => 'http://www.example.com/', :body => 'good entry!' } }
post "/#{@post.id}", { check: "check", comment: { name: "lokka tarou", homepage: "http://www.example.com/", body: "good entry!" } }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.
Line is too long. [141/80]

subject { get '/'; last_response.body }
it { should match('Test Site') }
context "/" do
subject { get "/"; last_response.body }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Do not use semicolons to terminate expressions.

it "should not create a user when two password does not match" do
user = { name: "lokka tarou",
email: "tarou@example.com",
password: "test",

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Align the elements of a hash literal if they span more than one line.

post '/admin/users', { :user => user }
it "should not create a user when two password does not match" do
user = { name: "lokka tarou",
email: "tarou@example.com",

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Align the elements of a hash literal if they span more than one line.

email: "tarou@example.com",
password: "test",
password_confirmation: "test" }
post "/admin/users", { user: user }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

user = { name: "lokka tarou",
email: "tarou@example.com",
password: "test",
password_confirmation: "test" }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Align the elements of a hash literal if they span more than one line.

it "should create a new user" do
user = { name: "lokka tarou",
email: "tarou@example.com",
password: "test",

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Align the elements of a hash literal if they span more than one line.

last_response.body.should == "(function() {\n console.log(\"Hello, It's me!\");\n\n}).call(this);\n"
get "/theme/jarvi/script.js"
last_response.body.should \
eq("(function() {\n console.log(\"Hello, It's me!\");\n\n}).call(this);\n")

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Line is too long. [84/80]

last_response.body.should_not match(/<a href="\/9">Continue reading\.\.\.<\/a>\n*[ \t]+<\/div>/)
get "/post-with-more"
last_response.body.should_not \
match(/<a href="\/9">Continue reading\.\.\.<\/a>\n*[ \t]+<\/div>/)

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Use %r around regular expression.

get '/'
last_response.body.should match(/<p>a<\/p>\n\n<a href="\/[^"]*">Continue reading\.\.\.<\/a>\n*[ \t]+<\/div>/)
regexp = \
/<p>a<\/p>\n\n<a href="\/[^"]*">Continue reading\.\.\.<\/a>\n*[ \t]+<\/div>/

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Use %r around regular expression.
Line is too long. [88/80]

it 'should displayed 10' do
subject.scan(/<h2 class="title"><a href=".*\/[^"]*">Test Post.*<\/a><\/h2>/).size.should eq(10)
let(:regexp) do
/<h2 class="title"><a href=".*\/[^"]*">Test Post.*<\/a><\/h2>/

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Use %r around regular expression.

put '/admin/mobile_themes', { :title => 'jarvi_mobile' }
context "PUT /admin/mobile_themes" do
it "should change the mobile theme" do
put "/admin/mobile_themes", { title: "jarvi_mobile" }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

context "POST /admin/posts" do
it "should create a new post" do
sample = attributes_for(:post, slug: "created_now")
post "/admin/posts", { post: sample }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

last_response.body.should match('Draft Post')
context "with draft option" do
it "should show only draft posts" do
get "/admin/posts", { draft: "true" }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

put "/admin/pages/#{@page.id}", { :page => { :body => 'updated' } }
context "PUT /admin/pages/:id" do
it "should update the page\"s body " do
put "/admin/pages/#{@page.id}", { page: { body: "updated" } }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

context "POST /admin/pages" do
it "should create a new page" do
sample = attributes_for(:page, slug: "dekitate")
post "/admin/pages", { page: sample }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

last_response.body.should match('Draft Page')
context "with draft option" do
it "should show only draft pages" do
get "/admin/pages", { draft: "true" }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Redundant curly braces around a hash parameter.

@morygonzalez morygonzalez force-pushed the morygonzalez:hush-up-houndci branch from 5a9bdc0 to 64f89f3 Feb 25, 2018

end

describe '#description' do
[:kramdown, :redcloth, :wikicloth].each do |markup|

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Use %i or %I for an array of symbols.

let(:entry) { create(:entry) }
before { entry.tag_collection = 'foo,bar' }
it 'should update tags' do
expect { entry.save }.to change { entry.tags }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Parenthesize the param change { entry.tags } to make sure that the block will be associated with the change method call.

@@ -20,7 +22,7 @@

it 'custom_permalink_parse split path valid and return Hash' do
custom_permalink_parse('/2011/01/09/welcome').should ==
{:year=>"2011", :monthnum=>"01", :day=>"09", :slug=>"welcome"}
{:year=>'2011', :monthnum=>'01', :day=>'09', :slug=>'welcome'}

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Space inside { missing.
Use the new Ruby 1.9 hash syntax.
Surrounding space missing for operator =>.
Space inside } missing.

follow_redirect!
last_response.body.should match('should include')
Option.permalink_format.should == "/%year%/%id%"
Option.permalink_enabled.should == "false"
Option.permalink_format.should == '/%year%/%id%'

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Operator == used in void context.

follow_redirect!
last_response.body.should match('not closed')
Option.permalink_format.should == "/%year%/%id%"
Option.permalink_enabled.should == "false"
Option.permalink_format.should == '/%year%/%id%'

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Operator == used in void context.

.archive
%h1 Archive
%ul
- months.each do |month|
%li.month
%a{:href => url("/#{month.year}/#{month.month}/")}
%a{href: url("/#{month.year}/#{month.month}/")}

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

@@ -96,22 +96,22 @@
%ul
- Tag.all.each do |tag|
%li.tag
%a{:href => url(tag.link)}= tag.name
%a{href: url(tag.link)}= tag.name

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

%button.submit{:onclick => "submit()"} Search
%form{action: url("/search/"), method: "get"}
%input.text_field{name: "query", type: "text"}/
%button.submit{onclick: "submit()"} Search

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

%input.text_field{:name => "query", :type => "text"}/
%button.submit{:onclick => "submit()"} Search
%form{action: url("/search/"), method: "get"}
%input.text_field{name: "query", type: "text"}/

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

%form{:action => url("/search/"), :method => "get"}
%input.text_field{:name => "query", :type => "text"}/
%button.submit{:onclick => "submit()"} Search
%form{action: url("/search/"), method: "get"}

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

@morygonzalez morygonzalez force-pushed the morygonzalez:hush-up-houndci branch from 64f89f3 to 57c6ac4 Feb 25, 2018

%nav
%ul
- Page.all.each do |page|
%li= link_to page.title, url(page.link)
%li
%a{:href => url("/index.atom")} Feed
%a{href: url("/index.atom")} Feed

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

@@ -75,17 +75,17 @@
.inner
.title
%h1
%a{:href => url("/")}= @site.title
%a{href: url("/")}= @site.title

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 25, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

@morygonzalez morygonzalez force-pushed the morygonzalez:hush-up-houndci branch from 57c6ac4 to 33cebde Feb 26, 2018

@morygonzalez morygonzalez changed the title [WIP] Hush-up houndci-bot Hush-up houndci-bot Feb 26, 2018

$(".gist-file").click(function () {
$(this).children(".gist-meta").toggle();
})
$(".gist-file a[href^='https://gist.github.com/raw/']").each(function(){
$('.gist-file a[href^="https://gist.github.com/raw/"]').each(function() {

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 26, 2018

Line is too long. [81/80]

/[if lt IE 9]
%script{:src => "http://html5shiv.googlecode.com/svn/trunk/html5.js"}
%script{src: "http://html5shiv.googlecode.com/svn/trunk/html5.js"}

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 26, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

%link{href: url("/index.atom"), rel: "alternate", title: @title, type: "application/atom+xml"}/
%link{href: "#{@theme.path}/style.css", rel: "stylesheet", type: "text/css"}/
%script{src: "http://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js", type: "text/javascript"}
%script{src: "#{@theme.path}/javascripts/gist.js", type: "text/javascript"}

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 26, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

%meta{content: @site.meta_keywords, name: "keywords"}/
%link{href: url("/index.atom"), rel: "alternate", title: @title, type: "application/atom+xml"}/
%link{href: "#{@theme.path}/style.css", rel: "stylesheet", type: "text/css"}/
%script{src: "http://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js", type: "text/javascript"}

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 26, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace
Line is too long. [108/80]

%meta{content: @site.meta_description, name: "description"}/
%meta{content: @site.meta_keywords, name: "keywords"}/
%link{href: url("/index.atom"), rel: "alternate", title: @title, type: "application/atom+xml"}/
%link{href: "#{@theme.path}/style.css", rel: "stylesheet", type: "text/css"}/

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 26, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace
Line is too long. [81/80]

%script{:src => "#{@theme.path}/javascripts/gist.js", :type => "text/javascript"}
%meta{content: @site.meta_description, name: "description"}/
%meta{content: @site.meta_keywords, name: "keywords"}/
%link{href: url("/index.atom"), rel: "alternate", title: @title, type: "application/atom+xml"}/

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 26, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace
Line is too long. [99/80]

%script{:src => "http://ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js", :type => "text/javascript"}
%script{:src => "#{@theme.path}/javascripts/gist.js", :type => "text/javascript"}
%meta{content: @site.meta_description, name: "description"}/
%meta{content: @site.meta_keywords, name: "keywords"}/

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 26, 2018

Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

@morygonzalez morygonzalez force-pushed the morygonzalez:hush-up-houndci branch from 33cebde to 406a128 Mar 4, 2018

%br/
%input#permalink_format{'name' => 'format', 'type' => 'text', 'value' => flash[:permalink_format] || @format}
%input#permalink_format{ name: :format, type: :text, value: flash[:permalink_format] || @format }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Mar 4, 2018

id attribute must be in lisp-case

This comment has been minimized.

Copy link
@morygonzalez

morygonzalez Mar 4, 2018

Author Member

I made this ignorable by setting IdNames linter disabled in .haml-lint_todo.yml. Because it may have unpredictable side effects on JavaScript and CSS.

%input#permalink_enable{'name' => 'enable', 'type' => 'checkbox', 'value' => '1', 'checked' => @enabled||nil}
%label{'for' => 'permalink_enable'}= t('permalink.enable')
%input{ name: :enable, type: :hidden, value: 0 }
%input#permalink_enable{ name: :enable, type: :checkbox, value: '1', checked: @enabled || nil }

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Mar 4, 2018

id attribute must be in lisp-case

%span(id="upload-disabled-warning" style="display: none")= t('file_upload.notice.unavailable_with_wysiwyg')
= f.label :body, caption: t("#{@name}.body")
%br
%span{ id: 'upload-disabled-warning', style: 'display: none' }= t('file_upload.notice.unavailable_with_wysiwyg')

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Mar 4, 2018

Do not use inline style attributes

This comment has been minimized.

Copy link
@morygonzalez

morygonzalez Mar 4, 2018

Author Member

InlineStyles linter is also disabled to prevent style from getting broken.

html += "<li><a href=\"#{bread[:link]}\">#{bread[:name]}</a></li>"
} + "<li>#{@bread_crumbs[-1][:name]}</li></ol>"
end + "<li>#{@bread_crumbs[-1][:name]}</li></ol>"

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Mar 4, 2018

Do not place comments on the same line as the end keyword.

@morygonzalez morygonzalez force-pushed the morygonzalez:hush-up-houndci branch from 406a128 to 7ae5c79 Mar 4, 2018

Hush up houndci-bot
Add frozen_string_literal magic comment to every .rb file

@morygonzalez morygonzalez force-pushed the morygonzalez:hush-up-houndci branch from 7ae5c79 to 4f29f4b Mar 4, 2018

@morygonzalez

This comment has been minimized.

Copy link
Member Author

commented May 26, 2018

@komagata Sorry for being long time untouched. My work is done. I forgot to ask you reviewing. Can you please review this pull request?

@komagata

This comment has been minimized.

Copy link
Member

commented May 28, 2018

@morygonzalez Looks good, thank you.

@komagata komagata merged commit 501caa2 into lokka:master May 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound 3 violations found.

@morygonzalez morygonzalez deleted the morygonzalez:hush-up-houndci branch Jun 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.