New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jwysiwyg with quill #237

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
2 participants
@morygonzalez
Member

morygonzalez commented Jun 16, 2018

closes #233

2018-06-17 5 47 43

  • Drop jwysiwyg, instead introduce Quill
  • Remove unused css files
  • Add npm kind of things
  • Add rake task to build JavaScript file

Extras

  • Fix docker-compose.yml typo
@@ -17,7 +17,7 @@ services:
command: ["bundle", "exec", "rackup", "-o", "0.0.0.0"]
volumes:
- .:/app
- bundle:/user/local/bundle
- bundle:/usr/local/bundle

This comment has been minimized.

@morygonzalez

morygonzalez Jun 16, 2018

Member

😅

@@ -16,7 +16,6 @@
.field
= f.label :body, caption: t("#{@name}.body")
%br
%span{ id: 'upload-disabled-warning', style: 'display: none' }= t('file_upload.notice.unavailable_with_wysiwyg')

This comment has been minimized.

@morygonzalez

morygonzalez Jun 16, 2018

Member

Quill supports file upload. So we can upload files while using wysiwyg if S3 storage is configured.

@komagata

This comment has been minimized.

Member

komagata commented Jun 18, 2018

@komagata komagata merged commit e8b5a11 into master Jun 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@komagata komagata deleted the replace-jwysiwyg-with-quill branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment