New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #278 - Adds loklak wordcloud app #279

Merged
merged 1 commit into from Jul 31, 2017

Conversation

Projects
None yet
6 participants
@djmgit
Member

djmgit commented Jul 28, 2017

fixes issue #278, adding loklak wordcloud app.

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.
@djmgit

This comment has been minimized.

Show comment
Hide comment
@djmgit

djmgit Jul 29, 2017

Member

Test link: http://loklakapps.surge.sh/LoklakWordCloud/
@kavithaenair @singhpratyush @Achint08 please review

This is the first basic version of loklak word cloud app. The basic feature of generating the word cloud has been implemented.
In the next iterations, filters (date, count, hashtags, mentions) will be added, error handling will be done and option to export the wordcloud to image and save will be added.

Member

djmgit commented Jul 29, 2017

Test link: http://loklakapps.surge.sh/LoklakWordCloud/
@kavithaenair @singhpratyush @Achint08 please review

This is the first basic version of loklak word cloud app. The basic feature of generating the word cloud has been implemented.
In the next iterations, filters (date, count, hashtags, mentions) will be added, error handling will be done and option to export the wordcloud to image and save will be added.

@djmgit djmgit changed the title from [WIP] fixes #278 - Adds loklak wordcloud app to fixes #278 - Adds loklak wordcloud app Jul 29, 2017

@Achint08

This comment has been minimized.

Show comment
Hide comment
@Achint08

Achint08 Jul 29, 2017

Nice Work! :)

Just please see that the query data binding works fine.
screen shot 2017-07-30 at 3 10 35 am

Achint08 commented Jul 29, 2017

Nice Work! :)

Just please see that the query data binding works fine.
screen shot 2017-07-30 at 3 10 35 am

@singhpratyush

This is an awesome idea and a good implementation. Kudos!

Please consider following points -

  • Clean the words so that we, becomes we and so on.
  • Implement a good gradient according to frequency of the words.
  • Make the words clickable so that whenever we click on a word, the current cloud is replaced by the word's cloud.
  • Make hashtags functional.
@vibhcool

Looks good 👍
For next PRs:
@singhpratyush's points + could you modify LoklakWordCloud/js/jqcloud.min.js for:-

  1. different sizes of image
  2. different distances of distribution of words
  3. Different colors of words and backgrounds
@djmgit

This comment has been minimized.

Show comment
Hide comment
@djmgit

djmgit Jul 30, 2017

Member

@singhpratyush thanks a lot for the suggestions.
I will clean the words, and solve the hashtag issue. I will address the the points related to word clicking feature and gradient in subsequent PRs as they are separate features and this is just the basic implementation of the app.
@vibhcool By different size of image, you are referring to the word cloud size right? That can be done :)
As of different colours, I will be implementing a better gradient.
Could please elaborate a little about the second point regarding distance :)

Member

djmgit commented Jul 30, 2017

@singhpratyush thanks a lot for the suggestions.
I will clean the words, and solve the hashtag issue. I will address the the points related to word clicking feature and gradient in subsequent PRs as they are separate features and this is just the basic implementation of the app.
@vibhcool By different size of image, you are referring to the word cloud size right? That can be done :)
As of different colours, I will be implementing a better gradient.
Could please elaborate a little about the second point regarding distance :)

@vibhcool

This comment has been minimized.

Show comment
Hide comment
@vibhcool

vibhcool Jul 30, 2017

Member

@djmgit , by distance, I meant words are separated by some parameter lets say it d, if this value d is multiplied by a number taken from user if he wants, then distribution of words can be observed in different ways. You will have to see if this can be done. this will be fun :)

Member

vibhcool commented Jul 30, 2017

@djmgit , by distance, I meant words are separated by some parameter lets say it d, if this value d is multiplied by a number taken from user if he wants, then distribution of words can be observed in different ways. You will have to see if this can be done. this will be fun :)

fixes #278 - Adds loklak wordcloud app
fixes issue #278, added basic version of loklak word cloud app.
@djmgit

This comment has been minimized.

Show comment
Hide comment
@djmgit

djmgit Jul 31, 2017

Member

Test link: http://loklakapps.surge.sh/LoklakWordCloud/

@kavithaenair @singhpratyush @Achint08 please re-review, solved hashtag problem.

Member

djmgit commented Jul 31, 2017

Test link: http://loklakapps.surge.sh/LoklakWordCloud/

@kavithaenair @singhpratyush @Achint08 please re-review, solved hashtag problem.

@singhpratyush

Nice work!

Please open an issue for clickable words in the cloud.

@mariobehling mariobehling merged commit 4dbd466 into loklak:master Jul 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment