Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes: #286: Added TwitterFollowersInsight App #291
For the reviewers
Please see these suggestions for susequent PRs or in this PR:-
- Empty page doesn't looks nice, could you add a intro page be added?
or show any default output
- IMHO username shall change on clicking the button, but not on typing.
- Also for users with large no. of followers can have hidden. you can show limited followers and a
morelink to unhide rest followers
views about the suggestions?
It is unclear what additional value this app is providing compared to sidebar of loklak.org e.g. here http://loklak.org/search?query=from%3Afossasia
We already have this and you are simply replicating it. Does not make sense.
Please compare existing closed source services and this with your work. Here sth. comparable that would be expected as an outcome of a student in the third term: https://moz.com/followerwonk/analyze/fossasia
Which services have you looked at?
A page with more user information such as followerwonk would make a good app. Right now I see a very rudimentary replicate that would have been great before GSoC.
changed the title from
Fixes: #286: Added TwitterFollowersInsight App
[WIP] Fixes: #286: Added TwitterFollowersInsight App
Aug 9, 2017
PR looks good, please look into the following problems.
Some more padding towards the left of the label will look good I guess. It is almost touching the edge.
If I enter a name and hit search it shows result. If I do not enter anything it shows popup. Next time when I enter something and hot enter it again shows popup.
@kavithaenair the error is still there
steps to reproduce
Problem does not occur when button is pressed