Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WorldMoodTracker] Add streaming feature #315

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@singhpratyush
Copy link
Member

commented Aug 20, 2017

Short description

Fixes #314.

Changes:

  • Modal to display Tweets on clicking a country.
  • Start and stop streams from triggers at different components.

Link: https://singhpratyush.github.io/world-mood-tracker/index.html

Screenshots for the change:

screenshot from 2017-08-20 21 39 51

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

@singhpratyush singhpratyush force-pushed the singhpratyush:314 branch from 061e257 to c2cf7d0 Aug 20, 2017

@singhpratyush

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2017

if (this.eventSource) {
return;
}
// this.eventSource = new EventSource(host + '/api/stream.json?channel=' + 'all');

This comment has been minimized.

Copy link
@djmgit

djmgit Aug 20, 2017

Member

You may remove this.

This comment has been minimized.

Copy link
@singhpratyush

singhpratyush Aug 20, 2017

Author Member

@djmgit: Removed the line.

@djmgit
Copy link
Member

left a comment

App is displaying tweets, nice work 👍 Please see my comment inline.

@singhpratyush singhpratyush force-pushed the singhpratyush:314 branch from c2cf7d0 to 5596751 Aug 20, 2017

@kavithaenair
Copy link
Member

left a comment

How can i get back to the page which was showing map, from here:
image

@singhpratyush

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2017

@kavithaenair: You can click the area between the modal and address bar to hide it.

@djmgit

This comment has been minimized.

Copy link
Member

commented Aug 21, 2017

@singhpratyush the modal is not being properly displayed on mobile screen.

@singhpratyush

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2017

@djmgit: Could you please share the display size?

@vibhcool
Copy link
Member

left a comment

Works fine for me. but shouldn't the host link be set to Loklak?

@singhpratyush

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2017

@vibhcool: Currently, streaming is not enabled for the main deployments of loklak. That's why I am using this deployment.

@djmgit

This comment has been minimized.

Copy link
Member

commented Aug 21, 2017

world2

modal is working fine, I guess it was some other problem, its working fine now, please have a look at this issue. Words are moving out of the boundary. Not sure about the exact break point, I encountered it at around 350px.

@djmgit

This comment has been minimized.

Copy link
Member

commented Aug 21, 2017

Also in your subsequent PRs can you put a close button on your modal? I guess it would improve the UX as the area to click on in order to hide the modal is very less :)

@singhpratyush singhpratyush force-pushed the singhpratyush:314 branch 2 times, most recently from 13e4581 to 138c2e3 Aug 22, 2017

@singhpratyush

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2017

@djmgit: Made the changes.

@Achint08 @hemantjadon @kavithaenair @SKrPl @vibhcool: Please review.

@vibhcool

This comment has been minimized.

Copy link
Member

commented Aug 22, 2017

link isn't working 😅

@singhpratyush singhpratyush force-pushed the singhpratyush:314 branch from 138c2e3 to 4f323a6 Aug 24, 2017

@djmgit

djmgit approved these changes Aug 25, 2017

Copy link
Member

left a comment

Nice work 👍

@Achint08
Copy link

left a comment

Good work @singhpratyush :)

@mariobehling

This comment has been minimized.

Copy link
Member

commented Aug 25, 2017

This is all great, but we don't have reliable search results that the server provides. Therefore the service works unreliably. Please help to make all GSoc projects a success and ensure everyone passes. The pre-requisite for this is: The search results need to work reliably.

@singhpratyush singhpratyush force-pushed the singhpratyush:314 branch 2 times, most recently from e17757f to 49e6426 Aug 25, 2017

@singhpratyush singhpratyush force-pushed the singhpratyush:314 branch from 49e6426 to 63c82fe Sep 3, 2017

@singhpratyush

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2017

@mariobehling: We've increased the timeout in order to get better search results in the server.

But this pull request is not related to the search results in any way. Please merge this.

Thanks.

@Ishaan28malik
Copy link

left a comment

It works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.