Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching for aggregation response #1333

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
4 participants
@singhpratyush
Copy link
Member

commented Jul 19, 2017

Short description

Fixes #1328.

Adds caching of aggregation data from Elasticsearch.

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.
@codecov-io

This comment has been minimized.

Copy link

commented Jul 19, 2017

Codecov Report

Merging #1333 into development will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##             development   #1333      +/-   ##
================================================
- Coverage           9.13%   9.11%   -0.03%     
  Complexity           401     401              
================================================
  Files                201     202       +1     
  Lines              17656   17697      +41     
  Branches            3278    3286       +8     
================================================
  Hits                1613    1613              
- Misses             15741   15782      +41     
  Partials             302     302
Impacted Files Coverage Δ Complexity Δ
...loklak/api/aggregation/ClassifierServletCache.java 0% <0%> (ø) 0 <0> (?)
.../org/loklak/api/aggregation/ClassifierServlet.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7313216...4ee66fd. Read the comment docs.

@singhpratyush singhpratyush force-pushed the singhpratyush:1328 branch 3 times, most recently from 57c30c7 to 0ad08df Jul 19, 2017

@singhpratyush singhpratyush force-pushed the singhpratyush:1328 branch from 0ad08df to 4ee66fd Jul 19, 2017

@singhpratyush singhpratyush changed the title [WIP] Add caching for aggregation response Add caching for aggregation response Jul 19, 2017

@singhpratyush

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2017

@Achint08 @djmgit @hemantjadon @kavithaenair @SKrPl @vibhcool: Please review and let me know if a test link is required.

@Achint08
Copy link
Contributor

left a comment

LGTM 👍

@mariobehling mariobehling merged commit ee880ff into loklak:development Jul 21, 2017

2 of 4 checks passed

codecov/patch 0% of diff hit (target 9.13%)
Details
codecov/project 9.11% (-0.03%) compared to 7313216
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.