New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MQTT Publisher with initialization in DAO #1393

Merged
merged 1 commit into from Aug 5, 2017

Conversation

Projects
None yet
7 participants
@singhpratyush
Member

singhpratyush commented Aug 3, 2017

Short description

Fixes #1392.

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.
@codecov-io

This comment has been minimized.

codecov-io commented Aug 3, 2017

Codecov Report

Merging #1393 into development will decrease coverage by 0.01%.
The diff coverage is 6.45%.

Impacted file tree graph

@@               Coverage Diff                @@
##             development   #1393      +/-   ##
================================================
- Coverage           9.16%   9.15%   -0.02%     
  Complexity           405     405              
================================================
  Files                202     203       +1     
  Lines              17901   17932      +31     
  Branches            3303    3306       +3     
================================================
  Hits                1641    1641              
- Misses             15953   15983      +30     
- Partials             307     308       +1
Impacted Files Coverage Δ Complexity Δ
src/org/loklak/stream/MQTTPublisher.java 0% <0%> (ø) 0 <0> (?)
src/org/loklak/data/DAO.java 3.62% <33.33%> (+0.26%) 4 <0> (ø) ⬇️
src/org/loklak/harvester/TwitterScraper.java 51.42% <0%> (-0.48%) 35% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf499e1...bac941e. Read the comment docs.

@singhpratyush

This comment has been minimized.

Member

singhpratyush commented Aug 3, 2017

@djmgit

djmgit approved these changes Aug 3, 2017

Looks good

@SKrPl

SKrPl approved these changes Aug 4, 2017

Good work 👍

@mariobehling

This comment has been minimized.

Member

mariobehling commented Aug 5, 2017

Good job!

@mariobehling mariobehling merged commit b122c65 into loklak:development Aug 5, 2017

1 of 4 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
codecov/patch 6.45% of diff hit (target 9.16%)
Details
codecov/project 9.15% (-0.02%) compared to bf499e1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment