New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream servlet #1474

Merged
merged 1 commit into from Aug 20, 2017

Conversation

Projects
None yet
8 participants
@singhpratyush
Member

singhpratyush commented Aug 18, 2017

Short description

Fixes #1473.

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 18, 2017

Codecov Report

Merging #1474 into development will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##             development   #1474      +/-   ##
================================================
- Coverage           9.57%   9.52%   -0.06%     
+ Complexity           416     413       -3     
================================================
  Files                203     205       +2     
  Lines              18094   18128      +34     
  Branches            3323    3325       +2     
================================================
- Hits                1732    1726       -6     
- Misses             16036   16076      +40     
  Partials             326     326
Impacted Files Coverage Δ Complexity Δ
src/org/loklak/stream/StreamServlet.java 0% <0%> (ø) 0 <0> (?)
src/org/loklak/LoklakServer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
src/org/loklak/stream/MqttEventSource.java 0% <0%> (ø) 0 <0> (?)
src/org/loklak/api/search/QuoraProfileScraper.java 42.72% <0%> (-3.76%) 10% <0%> (-3%)
src/org/loklak/harvester/TwitterScraper.java 35.2% <0%> (+0.28%) 37% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adef28...06da91c. Read the comment docs.

codecov-io commented Aug 18, 2017

Codecov Report

Merging #1474 into development will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##             development   #1474      +/-   ##
================================================
- Coverage           9.57%   9.52%   -0.06%     
+ Complexity           416     413       -3     
================================================
  Files                203     205       +2     
  Lines              18094   18128      +34     
  Branches            3323    3325       +2     
================================================
- Hits                1732    1726       -6     
- Misses             16036   16076      +40     
  Partials             326     326
Impacted Files Coverage Δ Complexity Δ
src/org/loklak/stream/StreamServlet.java 0% <0%> (ø) 0 <0> (?)
src/org/loklak/LoklakServer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
src/org/loklak/stream/MqttEventSource.java 0% <0%> (ø) 0 <0> (?)
src/org/loklak/api/search/QuoraProfileScraper.java 42.72% <0%> (-3.76%) 10% <0%> (-3%)
src/org/loklak/harvester/TwitterScraper.java 35.2% <0%> (+0.28%) 37% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adef28...06da91c. Read the comment docs.

@singhpratyush

This comment has been minimized.

Show comment
Hide comment
@singhpratyush

singhpratyush Aug 18, 2017

Member

Test with JSFiddle -

screenshot from 2017-08-19 04 12 58

Member

singhpratyush commented Aug 18, 2017

Test with JSFiddle -

screenshot from 2017-08-19 04 12 58

@singhpratyush

This comment has been minimized.

Show comment
Hide comment
Member

singhpratyush commented Aug 19, 2017

@SKrPl

SKrPl approved these changes Aug 19, 2017

@djmgit

djmgit approved these changes Aug 20, 2017

@mariobehling mariobehling merged commit 2d9c27f into loklak:development Aug 20, 2017

2 of 4 checks passed

codecov/patch 0% of diff hit (target 9.57%)
Details
codecov/project 9.52% (-0.06%) compared to 2adef28
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment