Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eZ Platform 3 support #55

Merged
merged 20 commits into from Mar 24, 2020
Merged

eZ Platform 3 support #55

merged 20 commits into from Mar 24, 2020

Conversation

@emodric
Copy link
Collaborator

emodric commented Mar 19, 2020

eZ migrated to Symfony 5 and Twig 3 today.

@lolautruche

This comment has been minimized.

Copy link
Owner

lolautruche commented Mar 19, 2020

Thanks @emodric !
Could you please also update .travis.yml and the README?
Also, it seems that composer.json needs an update regarding security. I'd really appreciate if you could update as well ^^

@emodric

This comment has been minimized.

Copy link
Collaborator Author

emodric commented Mar 19, 2020

Updated README and Travis. Not sure about what you mean about security & composer.json ?

@lolautruche

This comment has been minimized.

@emodric

This comment has been minimized.

Copy link
Collaborator Author

emodric commented Mar 19, 2020

@lolautruche It seems that RepositoryAuthenticationProvider is not compatible with eZ Platform 3, but since eZ Platform 3 introduced the possiblity to login with email as well as username (ezsystems/ezpublish-kernel#2944), maybe we can just disable it on v3?

@emodric

This comment has been minimized.

Copy link
Collaborator Author

emodric commented Mar 19, 2020

See https://github.com/lolautruche/EzCoreExtraBundle/network/alerts

@lolautruche Can't see those, those are only for repo owners ;)

@lolautruche

This comment has been minimized.

Copy link
Owner

lolautruche commented Mar 19, 2020

@lolautruche It seems that RepositoryAuthenticationProvider is not compatible with eZ Platform 3, but since eZ Platform 3 introduced the possiblity to login with email as well as username (ezsystems/ezpublish-kernel#2944), maybe we can just disable it on v3?

Or maybe we should start a new major version...

@emodric

This comment has been minimized.

Copy link
Collaborator Author

emodric commented Mar 19, 2020

Or maybe we should start a new major version...

We can do that, yes, even better!

@emodric emodric changed the title Bump dependencies for eZ Platform 3 support eZ Platform 3 support Mar 19, 2020
@emodric emodric force-pushed the emodric:patch-5 branch from 78d2dd3 to 1fd88d7 Mar 19, 2020
@emodric

This comment has been minimized.

Copy link
Collaborator Author

emodric commented Mar 19, 2020

@lolautruche This is now more or less ready for review. I've removed support for email authentication and view parameters injection since it is implemeneted in eZ kernel now.

Email authentication is not compatible with eZ kernel 8 anyhow, but if you don't want to remove view parameters injection, I can revert it?

@emodric

This comment has been minimized.

Copy link
Collaborator Author

emodric commented Mar 20, 2020

So, it seems ezpublish-kernel is now ezplatform-kernel: ezsystems/ezplatform#510

Will update it here as soon as their PR is merged.

On the other hand, it might be okay to merge this without the change to at least have a tagged beta version with the old ezpublish-kernel name

Copy link
Owner

lolautruche left a comment

I'd rather keep parameters injection, but deprecate them.
Please check the docs in Resources/doc/ as well 😉 .
We also need an UPGRADE-3.0.md file, listing what was removed and what is deprecated (also the bumped dependencies maybe?).

@emodric emodric force-pushed the emodric:patch-5 branch from 77554fe to 64cb76f Mar 24, 2020
@emodric

This comment has been minimized.

Copy link
Collaborator Author

emodric commented Mar 24, 2020

@lolautruche I've reverted the removal of view parameters and removed obsolete docs.

There's already UPGRADE-3.0.md file in the root dir, however I don't know how relevant it is and what was the purpose of it originally.

@lolautruche

This comment has been minimized.

Copy link
Owner

lolautruche commented Mar 24, 2020

Thanks @emodric .
UPGRADE-3.0.md is stille relevant. It comes from 8f172ac#diff-0901ceb76939b17cd920bc69aa52d21f , so I guess we're still at least one PR away from v3 after this one 😉

@emodric

This comment has been minimized.

Copy link
Collaborator Author

emodric commented Mar 24, 2020

@lolautruche I've pushed an update to UPGRADE-3.0.md. WDYT?

@lolautruche lolautruche merged commit d7c7f8d into lolautruche:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.