Adding new LOLCOMMITS_FORK (or --fork) option to fork the runner capturing #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uring Use the LOLCOMMITS_FORK env variable or --fork argument in the lolcommits command to fork the runner capturing process to a new thread. Helps when the capture is slow and you want to return to a usable terminal prompt right away. Using fork, some plugins may prompt in your terminal after the initial capture. README also updated to explain this.
|
This has been merged. I added a test in 8fd8f1c to verify it doesn't break capture. (If you can think of a way to have the test actually verify we background successfully, that would be ideal!) |
mroth
added a commit
that referenced
this pull request
Jul 8, 2013
|
Thanks @mroth, I'll look into adding a test for that asap. |
|
Released to rubygems as part of |
|
|
||
| def fork_me?(&block) | ||
| if Choice.choices[:fork] || ENV['LOLCOMMITS_FORK'] | ||
| fork { yield block } |
There was a problem hiding this comment.
Maybe we should redirect STDOUT from within the child process.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Use the
LOLCOMMITS_FORKenv variable or--forkargument in the lolcommits command to fork the runner capturing process to a new thread.This helps when the capture is slow and you want to return to a usable terminal prompt right away. Using fork, some plugins may prompt in your terminal after the initial capture. I also updated the README.md to explain this.
This PR is particularly useful for capturing animated gifs!