Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"On Mission" status not displayed for soldiers #40

Closed
pledbrook opened this issue Mar 15, 2019 · 0 comments
Closed

"On Mission" status not displayed for soldiers #40

pledbrook opened this issue Mar 15, 2019 · 0 comments
Labels
blocker Must be fixed before initial release bug Something isn't working

Comments

@pledbrook
Copy link
Collaborator

pledbrook commented Mar 15, 2019 •
edited
Loading

Although soldiers that are infiltrating are blocked from being added to other missions, their displayed status does not reflect this situation.

Apparently Long War 2 made quite a few changes to the highlander classes in order to implement this behaviour. That may no longer be necessary as WOTC introduces the eStatus_CovertAction status that represents something similar.

So, we need to replace references to eStatus_OnMission with eStatus_CovertAction. We then need to override the display of the status so that it shows "On Mission" or "On Covert Action" as appropriate. A similar requirement seems to have been tackled by the community highlander in this issue and linked pull request.
@pledbrook pledbrook added bug Something isn't working blocker Must be fixed before initial release labels Mar 15, 2019
pledbrook added a commit that referenced this issue Apr 1, 2019
@pledbrook
Display on-mission type soldier statuses (#40)
16eaab4 
This commit uses an event added by the community highlander that allows mods
to override the soldier status strings displayed in soldier lists and the
armory screen. Now haven advisers and soldiers that are infiltrating missions
have appropriate status strings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker Must be fixed before initial release bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pledbrook