Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A tiny mistake in htlr_predict() #7

Closed
syumet opened this issue Jul 10, 2020 · 1 comment · Fixed by #8
Closed

A tiny mistake in htlr_predict() #7

syumet opened this issue Jul 10, 2020 · 1 comment · Fixed by #8
Assignees

Comments

@syumet
Copy link
Collaborator

syumet commented Jul 10, 2020

At predict.R line 41 - 48:

if (is.null(usedmc))
{
    if (is.null(burn))
        burn <- floor(no_mcspl * 0.1)
    if (is.null(thin))
        thin <- 1
    usedmc <- seq(burn + 1, no_mcspl, by = thin)
}

If burn == 0 for some reason, then the initial value will be used for prediction (recall that the length of the MCMC sample array is n.iter + 1, where the first entry stores the initial state). So the correct default usedmc should be seq(burn + 2, no_mcspl, by = thin), although it has very little impact on the results.

@syumet
Copy link
Collaborator Author

syumet commented Jul 10, 2020

I will fix it in the next PR.

@syumet syumet self-assigned this Jul 10, 2020
@syumet syumet linked a pull request Aug 28, 2020 that will close this issue
Merged
@syumet syumet closed this as completed in #8 Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant