fix: wait for backing image restoration finished before checking volume restoration #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing PASSED |
ChanYiLin
force-pushed
the
LH5085_support_system_backup_backingimage
branch
6 times, most recently
from
99a2d05
to
b854c8d
Compare
ChanYiLin
force-pushed
the
LH5085_support_system_backup_backingimage
branch
from
b854c8d
to
8f82537
Compare
c3y1huang
previously approved these changes
May 27, 2024
yangchiu
requested changes
May 27, 2024
…me restoration ref: longhorn/longhorn 8515 Signed-off-by: Jack Lin <jack.lin@suse.com>
ChanYiLin
force-pushed
the
LH5085_support_system_backup_backingimage
branch
from
8f82537
to
575734c
Compare
|
Hi @yangchiu You can wait for the fix PR to be merged, and test it and merge it after. |
yangchiu
approved these changes
May 31, 2024
|
Merge this first to reveal the issue of longhorn/longhorn-manager#2823. |
|
Hi @yangchiu Then for e2e flaky issue because of backup failure Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#8515
We should check if BackingImage is restored and before checking volume is restored.
Because Volume needs to wait until BackingImage to restored.
It may timeout checking the status , because Volume is not finished yet.