Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added patch to fix compiling with 4.7 kernel. Tested with 4.6 too. #18

Closed
wants to merge 1 commit into from
Closed

Conversation

VGerris
Copy link

@VGerris VGerris commented Jul 8, 2016

Basically do :s%/IEEE80211_BAND_5GHZ/NL80211_BAND_5GHZ/g
and :s%/IEEE80211_BAND_5GHZ/NL80211_BAND_5GHZ/g in vim.
Inspired by:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c?id=57fbcce37be7c1d2622b56587c10ade00e96afa3
Tested with 4.7 and 4.6 kernel, not further back.

Basically do :s%/IEEE80211_BAND_5GHZ/NL80211_BAND_5GHZ/g
and :s%/IEEE80211_BAND_5GHZ/NL80211_BAND_5GHZ/g in vim.
Inspired by:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c?id=57fbcce37be7c1d2622b56587c10ade00e96afa3
Tested with 4.7 and 4.6 kernel, not further back.
@VGerris VGerris mentioned this pull request Jul 8, 2016
@s7dhansh
Copy link

s7dhansh commented Jul 9, 2016

Just tested, it works for 4.4 too.

@longsleep
Copy link
Owner

Thanks. Before this can be merged it needs to become a patch for dkms and not a direct change of the source code. See the other patches in the Debian folder and activate it for kernel 4.4 and later.

@VGerris
Copy link
Author

VGerris commented Jul 16, 2016

Do you happen to have some instructions on the actual approach and the patch command used?
I am rather new to this. I can undo the original change and make some patch, but some help would be appreciated :).

@VGerris
Copy link
Author

VGerris commented Aug 18, 2016

Hi Longsleep, can you contact Alberto Milone to see if you can join efforts? He maintains the driver for Canonical as far as I know, he has a git repo here:
https://github.com/tseliot/bcmwl
There was some overlap in patchfiles, but all should be fixed in that one.
Maybe you can rebase?

Greetings,
Vincent

@longsleep
Copy link
Owner

Sure - but is my package still needed when Ubuntu has it by default? I can certainly merge but what's the difference then? The whole point of my package was to provide what's not available.

@VGerris
Copy link
Author

VGerris commented Aug 22, 2016

Hi,

I think it is included, yes.
Maybe it's the extra repositories.
You can check with Alberto Milone to be sure.
The package is listed here:
https://launchpad.net/~broadcom-sta-hackers
but since I asked to commit he mentioned this git repo for that reason:
https://github.com/tseliot/bcmwl

I think the best thing is to have a chat with him and see what the best
option is?

It would be good to merge the efforts :).

Cheers,
Vincent

On Sun, Aug 21, 2016 at 9:44 PM, Simon Eisenmann notifications@github.com
wrote:

Sure - but is my package still needed when Ubuntu has it by default? I can
certainly merge but what's the difference then? The whole point of my
package was to provide what's not available.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#18 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAwdiTGJldhO9DlKFnLPbHJpX4py-C59ks5qiKqcgaJpZM4JH2CH
.

@cooks8
Copy link

cooks8 commented Sep 3, 2016

Just tested for 4.7.2. Worked like a charm. Excellent work

@longsleep
Copy link
Owner

Please try https://github.com/tseliot/bcmwl instead of my packaging.

@longsleep longsleep closed this Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants