Skip to content

Conversation

@mistryrakesh
Copy link
Contributor

This PR fixes generation of kotlin classes which handle properties having special characters.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #837 🦕

@google-cla google-cla bot added the cla: yes label Sep 28, 2021
@github-actions
Copy link
Contributor

Codegen Tests

0 files   -   1  0 suites   - 6   0s ⏱️ -57s
0 tests  - 58  0 ✔️  - 46  0 💤  - 12  0 ❌ ±0 

Results for commit 7f8838d. ± Comparison against base commit 4d1f789.

This pull request removes 58 tests.
Declaration miner should mine files matching the probe settings ‑ Declaration miner should mine files matching the probe settings
example mining CodeMiner ignores comments and ok ‑ example mining CodeMiner ignores comments and ok
example mining CodeMiner ignores ok and finds kotlin calls ‑ example mining CodeMiner ignores ok and finds kotlin calls
example mining CodeMiner ignores ok and finds ts calls ‑ example mining CodeMiner ignores ok and finds ts calls
example mining CodeMiner is empty for no sdk calls ‑ example mining CodeMiner is empty for no sdk calls
example mining CodeMiner mines a python file ‑ example mining CodeMiner mines a python file
example mining CodeMiner mines a ruby file ‑ example mining CodeMiner mines a ruby file
example mining CodeMiner mines a swift file ‑ example mining CodeMiner mines a swift file
example mining CodeMiner mines a typescript file ‑ example mining CodeMiner mines a typescript file
example mining MarkdownMiner accepts a source code file ‑ example mining MarkdownMiner accepts a source code file
…

@github-actions
Copy link
Contributor

Codegen Tests

  1 files  ±0    6 suites  ±0   55s ⏱️ -2s
58 tests ±0  46 ✔️ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit 6052426. ± Comparison against base commit 4d1f789.

Copy link

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix!

@jkaster jkaster merged commit 40b6b24 into main Sep 28, 2021
@jkaster jkaster deleted the rakeshmistry/fix-kt-special-properties branch September 28, 2021 16:10
@github-actions

This comment has been minimized.

jkaster added a commit that referenced this pull request Sep 30, 2021
* feat: request body validation before Run

also fixed RunIt form update when methods are changed

* fixed e2e tests but lost type tag tests

Need to expand e2e testing anyway

* moving prettier to scripts package

sadly, no version of it can run in the browser

* chore: refreshing hackathon app (#835)

* chore: refreshing hackathon app

also

 - updated TypeScript
 - updated Prettier
 - bumped ts-jest
 - updated ts-node

* Fixing APIX CI workflow

* feat: Update Kotlin SDK to use Gson instead of Jackson (#836)

* Updated Kotlin SDK to use Gson for serialization/deserialization.
* Added type adapter for AuthToken to handle constructor calls.
* Added smoke test to check deserialization ignores unknown properties.

* fix type resolution in various test:sdk suites

* fix: Property names with special characters in Kotlin SDK (#838)

This PR fixes generation of kotlin classes which handle properties having special characters.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://github.com/looker-open-source/sdk-codegen/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Appropriate docs were updated (if necessary)

Fixes #837 🦕

* added form encoded body validation

* allow . and - in encoded argument names

Co-authored-by: Rakesh Mistry <rakesh.dta@gmail.com>
Co-authored-by: Rakesh Mistry <rakeshmistry@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Property names with special characters in Kotlin SDK

3 participants